improve assembly error test coverage #25914
Open
+103
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlugg
reviewed
Nov 14, 2025
src/Sema.zig
Outdated
Comment on lines
16389
to
16393
| if (outputs_len != 0 or | ||
| inputs_len != 0 or | ||
| extra.data.clobbers != .none or | ||
| is_volatile) unreachable; // already checked by AstGen | ||
|
|
Member
There was a problem hiding this comment.
this is an odd spelling of
Suggested change
| if (outputs_len != 0 or | |
| inputs_len != 0 or | |
| extra.data.clobbers != .none or | |
| is_volatile) unreachable; // already checked by AstGen | |
| assert(outputs_len == 0); // validated by AstGen | |
| assert(inputs_len == 0); // validated by AstGen | |
| assert(extra.data.clobbers == .none); // validated by AstGen | |
| assert(!is_volatile); // validated by AstGen |
Member
There was a problem hiding this comment.
(BTW, the advantage of splitting them up in the above rather than using or is that if one of the assertions fails, you'll see in the stack trace what the specific condition was)
Contributor
Author
There was a problem hiding this comment.
yeah good point, i just kinda lazily edited the checks that were there before :p
xdBronch
force-pushed
the
push-nyrrvsryovqv
branch
from
7813c83 to
8125514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.