improve error message for unterminated string and character literals #22783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillLillis
force-pushed
the
invalid_byte_followup
branch
from
1216bca to
c51bd2a
Compare
Vexu
reviewed
Feb 6, 2025
WillLillis
force-pushed
the
invalid_byte_followup
branch
from
c51bd2a to
e21162f
Compare
Vexu
approved these changes
Feb 7, 2025
|
The more general code that you have added special case to avoid prints this: I find that to be sufficient and pleasing. No need for this added complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #21459 based on this comment.
This improves the error message for unterminated string and character literals. Instead of showing the invalid byte, the error message now indicates that the given literal is unterminated.