fix: make `zig cc` pass `-l`/`-L` like Clang/GCC for ELF #19818

a-khabarov · 2024-04-30T15:03:43Z

This PR is my attempt to fix #19699 by making the way zig cc passes -l/-L flags for ELF linking consistent with Clang and GCC.
I've added a test case that mimics the example in the issue description. Without the changes this PR makes to src, the new test case fails as expected with

========= expected to find: ==========================
NEEDED libfoo.so
========= but parsed file does not contain it: =======
dynamic section
RUNPATH foo
NEEDED foo/libfoo.so
NEEDED libc.so.6

I am not sure if test/tests.zig is the best place for it - I couldn't find a good way to test this in test/link/elf.zig or test/standalone.

a-khabarov · 2024-05-01T18:11:40Z

@motiejus @kubkon This PR builds on the functionality implemented in #15743 and should also fix cc_test not working correctly when using hermetic_cc_toolchain as mentioned in #15743 (comment).

test/tests.zig

a-khabarov · 2025-02-20T11:29:49Z

I am in the process of rebasing this on current mainline

a-khabarov · 2025-02-21T18:34:47Z

I've rebased this PR.

The fix itself is in src/link/Elf.zig.

The new test is in test/link/elf.zig. It follows the example from
#19699.

The rest of the changes are new functionality needed for the test:

omit_soname option for Build.Module, OverlayOptions.
This passes -fno-soname to the linker when enabled.
addLibraryPathSpecial for Build.Module, Build.Step.Compile.
Like addLibraryPath but for []const u8.
addRPathSpecial is also added for completeness.
setCwd for Build.Step.Compile.
Allows setting current directory for compile steps.
opt_cwd for evalZigProcess in Build.Step.
Allows running evalZigProcess in a specific directory.
Needed for setting current directory for compile steps.
--zig-lib-dir is now appended differently in Build.Step.Compile.
This is needed for compatibility with setCwd.

a-khabarov · 2025-02-24T19:30:41Z

I made some changes to avoid reconstructing the library name and directory in src/link/Elf.zig.
Everything is now passed via src/link.zig

This commit adds `addLibraryPathSpecial` for `Build.Module` and `Build.Step.Compile`. Like `addLibraryPath` but for `[]const u8`. `addRPathSpecial` is also added for `Build.Step.Compile` for completeness. This is needed to implement the new test in ziglang#19818.

This commit adds the `soname` option for `Build.Module` and `OverlayOptions`. This controls whether `-fsoname` or `-fno-soname` is passed to the linker. This is needed to implement the new test in ziglang#19818

We need this to implement the new test in ziglang#19818 This commits adds: * `setCwd` for `Build.Step.Compile`. Allows setting current directory for compile steps. * `opt_cwd` for `evalZigProcess` in `Build.Step`. Allows running `evalZigProcess` in a specific directory. Needed for setting current directory for compile steps. `--zig-lib-dir` is now appended differently in `Build.Step.Compile`. This is needed for compatibility with `setCwd`.

This commit adds the `omit_soname` option for `Build.Module` and `OverlayOptions`. This controls whether `-fsoname` or `-fno-soname` is passed to the linker. This is needed to implement the new test in ziglang#19818

We need this to implement the new test in ziglang#19818 This commits adds: * `setCwd` for `Build.Step.Compile`. Allows setting current directory for compile steps. * `opt_cwd` for `evalZigProcess` in `Build.Step`. Allows running `evalZigProcess` in a specific directory. Needed for setting current directory for compile steps. `--zig-lib-dir` is now appended differently in `Build.Step.Compile`. This is needed for compatibility with `setCwd`.

This commit adds the `soname` option for `Build.Module` and `OverlayOptions`. This controls whether `-fsoname` or `-fno-soname` is passed to the linker. This is needed to implement the new test in ziglang#19818

a-khabarov · 2025-02-25T20:59:40Z

I've removed everything related to setCwd and addLibraryPathSpecial, it turns out that they are not necessary.

lib/std/Build/Module.zig

This commit adds the `soname` option for `Build.Module` and `OverlayOptions`. This controls whether `-fsoname` or `-fno-soname` is passed to the linker. The `SOName` type is moved to `std.zig` to make it accessible in other modules. This is needed to implement the new test in ziglang#19818

lib/std/zig.zig

src/link.zig

test/link/elf.zig

This commit adds the `soname` option for `Build.Module` and `OverlayOptions`. This controls whether `-fsoname` or `-fno-soname` is passed to the linker. The `SoName` type is moved to `std.zig` to make it accessible in other modules. This is needed to implement the new test in ziglang#19818

This test follows the example from ziglang#19699.

alexrp

This seems okay to me. But I'm also not deeply familiar with this stuff, so it's possible that there are subtle details that I'm missing.

@andrewrk do you want to have a look before this gets merged?

andrewrk · 2025-04-18T19:48:26Z

Yes, thank you.

birunts · 2025-05-16T12:35:47Z

Hi, any updates on this topic? Is this going to be merged as it's already approved?

kubkon requested changes May 1, 2024

View reviewed changes

test/tests.zig Outdated Show resolved Hide resolved

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 5f810f0 to 1860048 Compare May 20, 2024 12:05

a-khabarov requested a review from kubkon May 20, 2024 12:23

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 9107b5a to 8d5fc36 Compare June 4, 2024 15:38

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from b4dcd83 to 094faf4 Compare June 17, 2024 10:02

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 094faf4 to b3cfcab Compare July 5, 2024 16:08

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from b3cfcab to f211d2d Compare July 26, 2024 12:26

alexrp added this to the 0.14.0 milestone Feb 19, 2025

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from f211d2d to 46752f5 Compare February 21, 2025 15:57

a-khabarov changed the title ~~fix: make zig cc pass -l/-L like Clang/GCC for ELF~~ fix: make zig cc pass -l/-L like Clang/GCC for ELF Feb 21, 2025

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 46752f5 to 2af0d55 Compare February 21, 2025 17:02

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 2af0d55 to b8f46fa Compare February 24, 2025 19:28

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from b8f46fa to 077f287 Compare February 25, 2025 15:37

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 077f287 to ac69db5 Compare February 25, 2025 15:44

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from ac69db5 to 0a646aa Compare February 25, 2025 20:51

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 0a646aa to b0c5bbb Compare February 25, 2025 20:53

andrewrk removed this from the 0.14.0 milestone Mar 1, 2025

a-khabarov mentioned this pull request Mar 4, 2025

zig tracking issue uber/hermetic_cc_toolchain#153

Open

alexrp self-requested a review April 15, 2025 19:25

alexrp self-assigned this Apr 15, 2025

alexrp reviewed Apr 16, 2025

View reviewed changes

lib/std/Build/Module.zig Outdated Show resolved Hide resolved

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from b0c5bbb to 7f064ee Compare April 16, 2025 19:15

alexrp reviewed Apr 16, 2025

View reviewed changes

lib/std/zig.zig Outdated Show resolved Hide resolved

alexrp reviewed Apr 16, 2025

View reviewed changes

src/link.zig Show resolved Hide resolved

alexrp reviewed Apr 16, 2025

View reviewed changes

test/link/elf.zig Show resolved Hide resolved

a-khabarov added 3 commits April 17, 2025 09:33

test: check that zig cc passes -l/-L like Clang/GCC for ELF

99261d9

This test follows the example from ziglang#19699.

link: make zig cc pass -l/-L like Clang/GCC for ELF

31be45e

a-khabarov force-pushed the fix-make-zig-cc-pass-l-L-like-Clang-GCC-for-ELF branch from 7f064ee to 31be45e Compare April 17, 2025 11:27

a-khabarov requested a review from alexrp April 17, 2025 11:37

alexrp approved these changes Apr 18, 2025

View reviewed changes

andrewrk self-requested a review April 18, 2025 19:48

alexrp removed their assignment Apr 19, 2025

chrisirhc mentioned this pull request May 26, 2025

regression: linking using filename of .so library results in "unable to find library" from zig 0.14 #23287

Open

This was referenced May 30, 2025

zig c++ linker puts relative path into NEEDED section of dynamically linked executable breaking rpath resolution #21219

Closed

Running bazel test on Linux fails on dynamically linked cc_test targets uber/hermetic_cc_toolchain#192

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: make `zig cc` pass `-l`/`-L` like Clang/GCC for ELF #19818

fix: make `zig cc` pass `-l`/`-L` like Clang/GCC for ELF #19818

Uh oh!

a-khabarov commented Apr 30, 2024

Uh oh!

a-khabarov commented May 1, 2024

Uh oh!

Uh oh!

a-khabarov commented Feb 20, 2025

Uh oh!

a-khabarov commented Feb 21, 2025

Uh oh!

a-khabarov commented Feb 24, 2025

Uh oh!

a-khabarov commented Feb 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexrp left a comment

Uh oh!

andrewrk commented Apr 18, 2025

Uh oh!

birunts commented May 16, 2025

Uh oh!

Uh oh!

Uh oh!

fix: make zig cc pass -l/-L like Clang/GCC for ELF #19818

Are you sure you want to change the base?

fix: make zig cc pass -l/-L like Clang/GCC for ELF #19818

Uh oh!

Conversation

a-khabarov commented Apr 30, 2024

Uh oh!

a-khabarov commented May 1, 2024

Uh oh!

Uh oh!

a-khabarov commented Feb 20, 2025

Uh oh!

a-khabarov commented Feb 21, 2025

Uh oh!

a-khabarov commented Feb 24, 2025

Uh oh!

a-khabarov commented Feb 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alexrp left a comment

Choose a reason for hiding this comment

Uh oh!

andrewrk commented Apr 18, 2025

Uh oh!

birunts commented May 16, 2025

Uh oh!

Uh oh!

fix: make `zig cc` pass `-l`/`-L` like Clang/GCC for ELF #19818

fix: make `zig cc` pass `-l`/`-L` like Clang/GCC for ELF #19818

a-khabarov commented Feb 25, 2025 •

edited

Loading