Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the whitepaper PDF #5

Closed
wants to merge 6 commits into from
Closed

Optimize the whitepaper PDF #5

wants to merge 6 commits into from

Conversation

Selicre
Copy link

@Selicre Selicre commented Apr 12, 2021

One whole kilobyte? We have no time for such bloat. This pull request optimizes the whitepaper PDF to the smallest possible version that retains the original paper size, opens correctly in both Firefox and Chrome, and also is detected as a pdf by github so it gets served with the correct mime type.

This doesn't actually open properly in Acrobat Reader, but who cares.

@zhuowei
Copy link
Owner

zhuowei commented Apr 12, 2021

Thank you so much! I'm probably going to keep the current version, but if I have time I'll try to debug why this doesn't work in Acrobat Reader.

@Selicre
Copy link
Author

Selicre commented Apr 12, 2021

It's likely because both firefox and chrome are rather permissive with terminating brackets, but Acrobat Reader itself isn't.

@randomdude999
Copy link

already working on acrobat support right now ;)

@zhuowei
Copy link
Owner

zhuowei commented Apr 12, 2021

Thanks.
To be honest, I'm probably not going to merge this, since using 994 bytes to display absolutely nothing is very much in agreement with the blockchain ethos.
However, my next project will be a PDF based project (since I was amazed by rsnous's Breakout game in a PDF demo and would like to try something similar) so I'm interested in learning PDF tricks for the future.

@Selicre
Copy link
Author

Selicre commented Apr 12, 2021

Well, rand made it open in acrobat reader anyway, if nothing else, this was fun. Acrobat still cowers in fear and tries to re-save it as a 4kB monstrocity, but hey, it works.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants