-
-
Notifications
You must be signed in to change notification settings - Fork 184
refactor: remove Theme.js code duplication #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor: remove Theme.js code duplication #359
Conversation
|
@veda1121 is attempting to deploy a commit to the shravan20's projects Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
frontend/src/util/themes/index.js(0 hunks)src/themes/themes.js(1 hunks)
💤 Files with no reviewable changes (1)
- frontend/src/util/themes/index.js
|
Thanks for the review! |
|
Hey @zhravan once check the PR |
Summary
Removed duplicated theme constants in
/frontend/src/util/themes/index.jsand consolidated them into a single exported object. This ensures a single source of truth for theme values and improves maintainability.Changes Made
Deleted redundant theme entries that were duplicated from the backend version. Kept only one consolidated export for all theme constants. Verified frontend imports and functionality remain intact.
Summary by CodeRabbit