-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Build & Push images as part of CI #44
Conversation
Hi, thanks for the PR! Could you make it so that it checks what permissions are allowed by the current token or make the push step optional, so the CI pipeline doesn't fail for PRs? |
I don't think there is a way to check it. Main issue in this case: head for this PR is my fork and it's trying to push image to your repository. @zhaofengli maybe it makes more sense to no run this on PRs at all? |
Yeah, that should work fine. |
@zhaofengli updated to only run on push to default branch and made it optional. |
❤️ LGTM. Sorry for the delay! |
I was trilled waiting for this docker image! So I was testing it now immediately. Unfortunately it doesn't seem to do anything yet. My docker-compose.yaml: version: '3.7'
services:
attic:
image: ghcr.io/zhaofengli/attic:latest When I run the service it just quits.
|
Unfortunately I have almost no experience yet in dockerizing this the "nix" way. 😅 I've only experience concocting Dockerfiles. 😁 |
I came up with an working example: version: '3.7'
services:
attic:
image: ghcr.io/zhaofengli/attic:latest
volumes:
- ./attic/server.toml:/attic/server.toml
- ./attic/server.db:/attic/server.db
- attic-storage:/attic/storage
command: [ "-f", "/attic/server.toml" ]
ports:
- 8080:8080
volumes:
attic-storage: |
I added #47. |
Add steps to build & push image to GitHub's container registry.
Steps setup to:
v
prefix if it's a tag build (I didn't update the job to run on tag events, though)latest
if it's a build onmain
branch.Validated on my fork.
Closes #16