Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported library related commits (and 1 minor for readme) from 0.8.1 build + my commits to add more strictness to zandronum #5

Open
wants to merge 23 commits into
base: dev0.8.1
Choose a base branch
from

Conversation

deguix
Copy link

@deguix deguix commented May 1, 2024

Tested against DnD's c252095f7c03ee6efc64c1946b9ca4349fe7d736 commit before it got updated to use 0.8.1 features. Everything succeeds. Might need to remove stuff related to things not supported (like the language removal support) and need to check for gzdoom support, but it includes a missed fix for it.

@TDRRmk2
Copy link

TDRRmk2 commented May 2, 2024

I'm on board with this PR, mostly.
Only thing I'd change is the way the engine is specified. A macro is a bit ugly. And ideally by default, all functions should be included, for SLADE compatibility (and because this is the case for the other BCS features changing behavior, they're all opt-in except for short circuiting).

There should be a way (maybe a pseudo preprocessor directive) to specify an engine in-source, that doesn't need to be before the zcommon include, and only then exclude the other functions. A way to set this on the command line as well.

Not just using a macro would be nice in case of engine-specific quirks as well. Eternity can have delays in functions so that should be allowed when it's the target engine, as an example.

I'll take a look into doing all this and if I can do it, I'll merge this PR. Thank you.

@deguix
Copy link
Author

deguix commented May 2, 2024

Please recheck, I made a mistake when getting everything into 1 file, and you commented right when I was trying to fix it. I found out later that getting everything into 1 file doesn't work because it seems bcc has a feature to import only certain functions (and things like macros don't get imported).

…ronum.bcs, also removed a duplicate line from master.bcs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants