-
Notifications
You must be signed in to change notification settings - Fork 35
docs: improve command descriptions #399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -249,7 +249,10 @@ const main = async (options: CctxOptions) => { | |
}; | ||
|
||
export const cctxCommand = new Command("cctx") | ||
.description("Query cross-chain transaction data in real-time") | ||
.summary("Track the status of a cross-chain transaction.") | ||
.description( | ||
"Queries the real-time status of a cross-chain transaction by its inbound transaction hash. You can control polling frequency, timeout, and target RPC endpoint." | ||
) | ||
.requiredOption("-h, --hash <hash>", "Inbound transaction hash") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 💡 Verification agent 🧩 Analysis chainPotential conflict: short flag “-h” is commonly reserved for help in Commander. Commander defaults the help option to “-h, --help”. Reusing “-h” for “--hash” can shadow/override help or cause conflicts depending on version/config. Suggest changing the short flag (e.g., “-i, --hash” or drop the short flag) in a follow-up PR to avoid a breaking CLI change here. Run this repo-scope check to find any other places where “-h” is used for non-help and whether help flags are customized: 🏁 Script executed: #!/usr/bin/env bash
# Find custom options using -h short flag
rg -nP --type=ts -C2 'requiredOption\(\s*["'\'']-h[,\s]'
# Check for help option customizations
rg -nP --type=ts -C2 '\.helpOption\(' Length of output: 608 Avoid using “-h” for hash flag—it conflicts with the default help shortcut Our repository-wide grep shows that the only occurrence of a custom • packages/commands/src/query/cctx.ts:256 This is a breaking CLI change. Please update the short flag for the hash parameter (for example, 🤖 Prompt for AI Agents
|
||
.option("-r, --rpc <rpc>", "RPC endpoint", DEFAULT_API_URL) | ||
.option( | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Copy looks good; ensure “Chain type” phrasing is consistent repo-wide
This aligns with the broader shift from “Account type” → “Chain type.” Quick scan recommended to ensure no remnants remain in other commands.
Expected: No matches.
Length of output: 424
Ensure “Chain type” phrasing is consistent across all account commands
We’ve detected one remaining instance of the old “Account type” label that needs updating for consistency.
• packages/commands/src/accounts/show.ts, line 47
Change
to
🤖 Prompt for AI Agents