Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update localnet #237

Merged
merged 6 commits into from
Feb 25, 2025
Merged

chore: update localnet #237

merged 6 commits into from
Feb 25, 2025

Conversation

fadeev
Copy link
Member

@fadeev fadeev commented Feb 24, 2025

  • Updated localnet to latest stable v6.0.1
  • Updated standard contracts to 2.0.0-rc2, because the new version of localnet requires longer timeout and universal NFT/token are importing the localnet script from npm, so I had to update the version
  • SPL-20 and Sui commands in comments in the Swap example

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Upgraded a key dependency across multiple example setups, shifting from a fixed pre-release version to a flexible version range. This change enables automatic adoption of compatible minor and patch updates, ensuring enhanced stability and smoother updates without altering the major release.
    • Adjusted sleep durations in local network scripts to allow for longer wait times after starting the local network, improving execution timing for subsequent operations.
    • Added new commands for executing swap operations in the local network script, enhancing functionality for users.

@fadeev fadeev requested a review from a team as a code owner February 24, 2025 14:08
Copy link

coderabbitai bot commented Feb 24, 2025

📝 Walkthrough

Walkthrough

The pull request updates the version specification of the dependency @zetachain/localnet in multiple package.json files across the project (located in the examples/call, examples/hello, examples/nft, examples/swap, and examples/token directories). The change replaces the fixed version "6.0.0-rc8" with the caret version "^6.0.1", allowing for minor and patch updates while maintaining the same major version. Additionally, the version of @zetachain/standard-contracts in examples/nft/package.json and examples/token/package.json is updated from "1.0.0-rc6" to "2.0.0-rc2". Some files also received minor formatting adjustments, such as the addition of a trailing newline.

Changes

File(s) Change Summary
examples/call/package.json Updated dependency version from "6.0.0-rc8" to "^6.0.1"; added trailing newline.
examples/hello/package.json Updated devDependencies version from "6.0.0-rc8" to "^6.0.1".
examples/nft/package.json Updated dependency versions: "@zetachain/localnet" from "6.0.0-rc8" to "^6.0.1"; "@zetachain/standard-contracts" from "1.0.0-rc6" to "2.0.0-rc2".
examples/swap/package.json Changed devDependencies version from "6.0.0-rc8" to "^6.0.1".
examples/token/package.json Updated dependency versions: "@zetachain/localnet" from "6.0.0-rc8" to "^6.0.1"; "@zetachain/standard-contracts" from "1.0.0-rc6" to "2.0.0-rc2"; added trailing newline.
examples/call/scripts/localnet.sh Increased sleep duration from 15 seconds to 20 seconds when starting the local network.
examples/hello/scripts/localnet.sh Increased sleep duration from 10 seconds to 20 seconds when starting the local network.
examples/swap/scripts/localnet.sh Increased sleep duration from 15 seconds to 20 seconds when starting the local network.

Possibly related PRs

  • Example descriptions in package.json #231: The changes in the main PR regarding the updates to the @zetachain/localnet dependency in examples/call/package.json are directly related to the similar updates made to the same dependency in examples/hello/package.json within the retrieved PR.
  • Swap: add Solana interact task #192: The changes in the main PR regarding the updates to the @zetachain/localnet dependency in package.json are related to the modifications in the retrieved PR, which also updates the same dependency in its package.json.

Suggested reviewers

  • andresaiello
  • 0xM3R

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5b47c2 and da83053.

📒 Files selected for processing (1)
  • examples/swap/scripts/localnet.sh (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • examples/swap/scripts/localnet.sh
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: test (examples/token)
  • GitHub Check: test (examples/swap)
  • GitHub Check: test (examples/nft)
  • GitHub Check: test (examples/hello)
  • GitHub Check: test (examples/call)
  • GitHub Check: slither (examples/swap, swap.sarif)
  • GitHub Check: slither (examples/call, call.sarif)
  • GitHub Check: slither (examples/hello, hello.sarif)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@@ -121,6 +133,38 @@ npx hardhat zetachain-swap \

npx hardhat localnet-check

# SUI deposit to ZetaChain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is sui disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's disabled, because this localnet script runs in CI, and we don't have Sui in CI yet. Most users will likely not have Sui either, so I'll have to come up with a way to maybe conditionally run these lines without adding to much complexity. Maybe as simple as command -v sui && npx ....

@fadeev fadeev merged commit 28a955b into main Feb 25, 2025
12 checks passed
@fadeev fadeev deleted the update-localnet-6.0.1 branch February 25, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants