Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some dead code for libzmq2 support, add some Cython type annotations #2082

Merged
merged 12 commits into from
Mar 17, 2025

Conversation

minrk
Copy link
Member

@minrk minrk commented Mar 16, 2025

  • move device from backend wrapping libzmq zmq_device removed in libzmq3 to sugar wrapping backend.proxy (unchanged behavior, just removed duplicate definitions in backends)
  • use more stable ABI-friendly buffer calls in new _asbuffer
  • new pure-python Cython mode could use some more type annotations to reduce unnecessary Python C-API calls
  • remove _check_version calls for unsupported versions

minrk added 8 commits March 16, 2025 12:33
it's a deprecated wrapper for zmq.proxy, no need to have two implementations
readme has some redundant content from docs, not in sync
clearer type annotations, avoid some unnecessary Python calls
less work when it's time to try stable ABI wheels
otherwise, LAST_ENDPOINT is annoying
@minrk minrk force-pushed the rm-dead-libzmq2 branch from 121b376 to 9891ce1 Compare March 16, 2025 12:55
minrk added 2 commits March 16, 2025 14:01
avoids OverflowError

hooray tests!
can't define module global C types
@minrk minrk force-pushed the rm-dead-libzmq2 branch from 9891ce1 to d33861b Compare March 16, 2025 13:02
@minrk minrk merged commit 2c768db into zeromq:main Mar 17, 2025
36 checks passed
@minrk minrk deleted the rm-dead-libzmq2 branch March 17, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant