scripts: kconfig: improve search results ordering using scoring #98147
+93
−108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartben
force-pushed
the
kconfig_search
branch
3 times, most recently
from
1a0e781 to
e4555ff
Compare
No reason to support Python 2 anymore. Signed-off-by: Benjamin Cabé <[email protected]>
_menu_scroll is declared as global but never used in _jump_to. Removing the unnecessary declaration. Signed-off-by: Benjamin Cabé <[email protected]>
Changed orient=VERTICAL to orient="vertical". VERTICAL wasn't imported; ttk.Panedwindow expects a string. Signed-off-by: Benjamin Cabé <[email protected]>
This implements the same improved sorting algorithm as was recently added to the documentation (see zephyrproject-rtos#98016), namely: - A match in a Kconfig symbol's name is given more weight than a match in its prompt. - Field-length normalization is applied so that the shorter the field, the higher its relevance (e.g. searching for "sensor" will now basically yield CONFIG_SENSOR as the top result as the query basically matches 100% of the symbol's name. Signed-off-by: Benjamin Cabé <[email protected]>
kartben
force-pushed
the
kconfig_search
branch
from
e4555ff to
4052afd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the same improved sorting algorithm as was recently added to the documentation (see #98016), namely:
Also clean up guiconfig script to get rid of legacy Python 2 support that's actually getting in the way by making CI compliance checks (PyLint and PyCompat) unhappy