tests: drivers: can: api: Add test teardown

[sebhub]

Stop the CAN device in the test teardown to leave the CAN device in a neutral state.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[henrikbrixandersen]

The description only says what you are changing, not why.

How come this is needed?

[sebhub]

The description only says what you are changing, not why.

How come this is needed?

When you run multiple test suites (for example can_classic and can_timing) in a single application, the can_timing test suite could fail since the CAN device is started when the timings are set.

[henrikbrixandersen]

When you run multiple test suites (for example can_classic and can_timing) in a single application, the can_timing test suite could fail since the CAN device is started when the timings are set.

How would you run these "in a single application"? These are two, distinct test suites, each an application on it's own.

[sebhub]

When you run multiple test suites (for example can_classic and can_timing) in a single application, the can_timing test suite could fail since the CAN device is started when the timings are set.

How would you run these "in a single application"? These are two, distinct test suites, each an application on it's own.

I don't use Zephyr directly. I use parts of Zephyr together with the RTEMS real-time operating system. The operating system and the Zephyr components are shipped as a static library. I would like to test the library in exactly one configuration. To reduce the test time, I would like to run multiple tests suites in one executable. The test suites support setup and teardown handlers, so from a testing point of view this should be fine.

[henrikbrixandersen]

don't use Zephyr directly. I use parts of Zephyr together with the RTEMS real-time operating system. The operating system and the Zephyr components are shipped as a static library.

This is in noway supported by Zephyr, sorry.

[sebhub]

don't use Zephyr directly. I use parts of Zephyr together with the RTEMS real-time operating system. The operating system and the Zephyr components are shipped as a static library.

This is in noway supported by Zephyr, sorry.

It works pretty well, however, the rejection of changes like this just makes it harder. What is the cost for the Zephyr project to properly teardown a test suite even if it is not strictly required in the current arrangement? The test support has all the means to do this and calling a single function which is already used by the test suite is a very small overhead. You already have to do the stop/start for some test cases.

[henrikbrixandersen]

What is the cost for the Zephyr project to properly teardown a test suite even if it is not strictly required in the current arrangement?

The cost is, that your use-case may break in another, unrelated way tomorrow. We have no means of verifying that this does not break (and it is not a supported use-case), so trying to maintain support for this will be chasing an undefined goal.

We cannot spend the time of upstream developers, maintainers, collaborators, and reviewers on this.