tests: drivers: counter: fix -Wformat error #98028
Open
+5
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Counter
area: Tests
Correct the error message in case counter failed to set top value. A format specifier for the error code was present in the zassert string but the error code was not passed to the zassert function causing a -Wformat error. Signed-off-by: Tim Pambor <[email protected]>
tpambor
force-pushed
the
maxim-zassert
branch
from
0a20d1b to
725d643
Compare
JarmouniA
requested changes
Oct 21, 2025
| err = counter_set_top_value(dev, &top_cfg); | ||
| zassert_equal(-ENOTSUP, err, | ||
| "%s: Counter failed to set top value: %d", dev->name); | ||
| "%s: Counter failed to set top value (err: %d)", dev->name, err); |
There was a problem hiding this comment.
Only this change is a fix, the others are rather enhancements, should go in a separate commit.
https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements
"Distinct, Logical Units of Change
(...)For example, adding a feature, fixing a bug, or refactoring existing code should be separate commits"
There was a problem hiding this comment.
I don't want two commits for such related change really
|
decsny
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the error message in case counter failed to set top value. A format specifier for the error code was present in the zassert string but the error code was not passed to the zassert function causing a -Wformat error.
Fixes #97834