scripts: west_commands: runners: nrf: A couple of improvements #98018
+36
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, for historical reasons (see f42cef9 and 58e0e31), the use of the --erase-mode command-line switch was reserved for the nRF54L family. But in fact this can be used (instead of --erase) for any of the Nordic ICs. This patch extends the usage of this switch regardless of family. Signed-off-by: Carles Cufi <[email protected]>
Add a new parameter to the ZephyrBinaryRunner init() method to specify whether this should be a dry run. The default is still taken from the _DRY_RUN global, but can be overridden by subclasses. Since the new dry_run parameter has a default value this should not break backwards compatibility with out-of-tree runners. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
commented
Oct 21, 2025
| @@ -483,12 +485,15 @@ class ZephyrBinaryRunner(abc.ABC): | |||
| commands in its constructor. The actual command execution is | |||
| handled in the run() method.''' | |||
|
|
|||
| def __init__(self, cfg: RunnerConfig): | |||
| def __init__(self, cfg: RunnerConfig, dry_run: bool=_DRY_RUN): | |||
pdgendt
previously approved these changes
Oct 22, 2025
In order to allow for users to invoke "west flash" without actual hardware connected but still running the logic and pregeneration of commands. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
force-pushed
the
nrf-runner-fixes
branch
from
cdb56ca to
05ff0f5
Compare
|
@pdgendt I realized I was missing parts of the implementation I had not committed. Can you please take another look? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages.