-
Notifications
You must be signed in to change notification settings - Fork 8.1k
drivers: uart: stm32: don't allow async TX on a suspended UART #98014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d6243af
to
d3c5746
Compare
Changed to zephyr/drivers/serial/uart_nrfx_uarte2.c Lines 387 to 394 in bbfd206
|
The change looks consistent to me. I think you need to rebase your change to successfully pass CI tests. |
d3c5746
to
65cdcc8
Compare
I noticed some of the earlier commits that changed this driver used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some of the earlier commits that changed this driver used uart too, so I suppose that is ok?
I guess it's fine. I would lean more towards the one that reflects the file tree path (drivers: serial: stm32: ...
) but it's not a strong opinion.
LGTM.
Return an error if trying to send data using a suspended UART, instead of blocking, possibly forever, for a transmission that will never succeed. Signed-off-by: Kamil Krzyżanowski <[email protected]>
65cdcc8
to
563e638
Compare
May as well fix it. There. |
|
Return an error if trying to send data using a suspended UART, instead of blocking, possibly forever, for a transmission that will never succeed.
Fixes #97063