Device runtime support for uart ns16550 and power domain support for siwx91x soc #94851

smalae · 2025-08-22T09:52:10Z

Added power domain node in siwg917.dtsi.
Updated UART device nodes to reference the newly added power domain.
Implemented the pm_action function to manage power domain transitions for the SoC.
Enable the pm device runtime driver support for the uart_ns16550 driver (only for devices that have an associated power domain enabled).

github-actions · 2025-08-22T09:53:39Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_silabs	zephyrproject-rtos/hal_silabs@`5bbf64e`	zephyrproject-rtos/hal_silabs@`edbd418` (`main`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

smalae · 2025-08-25T06:21:35Z

@bjarki-andreasen @fabiobaltieri, this PR addresses key challenges identified in the #94375 PR by introducing a power domain for the siwx91x SoC. It implements both turn_on and turn_off scenarios, ensuring that only devices associated with a power domain reconfigure their drivers upon wakeup. This aligns with the intended use case. Please provide your feedback.

bjarki-andreasen

Nice progress!

bjarki-andreasen · 2025-08-25T20:14:14Z

dts/arm/silabs/siwg917.dtsi

 		};

+		siwx91x_soc_pd: siwx91x_soc_pd {
+			compatible = "power-domain";


PM DEVICE RUNTIME is required for power domain power management, so the zephyr,pm-device-runtime-auto should be added to the the uart and power domain :)

"I'm encountering unexpected behavior after enabling CONFIG_PM_DEVICE_RUNTIME and adding zephyr,pm-device-runtime-auto to the UART node. The device isn't transitioning into low power mode as expected, and it appears to be stuck at the k_msleep() call. I'm currently investigating the issue.

This issue is resolved now.

fabiobaltieri · 2025-08-26T20:59:15Z

soc/silabs/silabs_siwx91x/siwg917/soc_siwx91x_power_domain.c

+	case PM_DEVICE_ACTION_TURN_OFF:
+		break;
+	default:
+		ret = -ENOTSUP;


return -ENOTSUP; here, return 0; at the end and drop ret

dts/arm/silabs/siwg917.dtsi

smalae · 2025-09-18T13:52:34Z

Hey, this needs a rebase.

Done

jerome-pouiller · 2025-09-18T14:47:55Z

drivers/serial/uart_ns16550.c

+	case PM_DEVICE_ACTION_TURN_ON:
+		return uart_ns16550_configure(dev, uart_cfg);
+	case PM_DEVICE_ACTION_TURN_OFF:
+		ret = clock_control_off(dev_cfg->clock_dev, dev_cfg->clock_subsys);


I assume we have to consider the case where clock_dev == NULL.

In that case, we should not perform any operations in 'PM_DEVICE_ACTION_TURN_OFF'. I've already handled that in my latest changes. But let me know if that can be handled differently.

jhedberg · 2025-09-18T15:18:23Z

@smalae rebase needed again (due to west.yml conflict). Could you also put some more content to the third commit message? It would be useful for it to contain an explanation for "why?" rather than just enumerating the answer to "what?" (which is less useful, since that can also be determined by looking at the diff).

jhedberg · 2025-09-19T07:28:25Z

@bjarki-andreasen @dcpleung could you have another look? Thanks.

dts/arm/silabs/siwg917.dtsi

soc/silabs/silabs_siwx91x/siwg917/soc_siwx91x_power_domain.c

1. Added siwx91x power domain node in siwg917.dtsi 2. Updated UART device nodes to reference the newly added power domain. 3. Implemented power domain driver to manage power domain transitions for the SoC. Signed-off-by: Sai Santhosh Malae <[email protected]>

This commit enables the pm device runtime driver support for the uart_ns16550 driver (only for devices that have an associated power domain enabled). Signed-off-by: Sai Santhosh Malae <[email protected]>

Removed CMSIS references from wiseconnect CMakeLists as they are no longer required with UART device runtime PM. Keeping them adds unnecessary compilation overhead. Signed-off-by: Sai Santhosh Malae <[email protected]>

Update hal_silabs version to latest commit: edbd418670ad8c7cad629a09df2ceee0bc23cf6d Signed-off-by: Sai Santhosh Malae <[email protected]>

sonarqubecloud · 2025-09-19T10:49:43Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fabiobaltieri

Cool, tested in in a couple platforms using this driver (it82002aw and rts5912) and they still work. Thanks.

github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Aug 22, 2025

smalae force-pushed the device-runtime-support-for-uart_ns16550-and-power-domain-support-for-siwx91x-soc branch 4 times, most recently from 2163c44 to 9f199b7 Compare August 25, 2025 06:04

smalae marked this pull request as ready for review August 25, 2025 06:18

zephyrbot added platform: Silabs Silicon Labs area: UART Universal Asynchronous Receiver-Transmitter labels Aug 25, 2025

zephyrbot requested review from asmellby, dcpleung, jerome-pouiller, jhedberg, Martinhoff-maker, mnkp, rettichschnidi and yonsch August 25, 2025 06:19

zephyrbot assigned dcpleung Aug 25, 2025

smalae requested review from fabiobaltieri and bjarki-andreasen August 25, 2025 06:20

smalae force-pushed the device-runtime-support-for-uart_ns16550-and-power-domain-support-for-siwx91x-soc branch from 9f199b7 to 9614fbf Compare August 25, 2025 07:04

bjarki-andreasen requested changes Aug 25, 2025

View reviewed changes

fabiobaltieri reviewed Aug 26, 2025

View reviewed changes

rettichschnidi removed their request for review September 10, 2025 07:06

smalae force-pushed the device-runtime-support-for-uart_ns16550-and-power-domain-support-for-siwx91x-soc branch 2 times, most recently from 24a91cf to a160b0c Compare September 16, 2025 15:33

asmellby reviewed Sep 16, 2025

View reviewed changes

dts/arm/silabs/siwg917.dtsi Outdated Show resolved Hide resolved

dts/arm/silabs/siwg917.dtsi Show resolved Hide resolved

smalae added DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added and removed DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Sep 18, 2025

jerome-pouiller reviewed Sep 18, 2025

View reviewed changes

smalae force-pushed the device-runtime-support-for-uart_ns16550-and-power-domain-support-for-siwx91x-soc branch from 6ebd6e2 to 2cb5f60 Compare September 19, 2025 06:15

github-actions bot removed DNM (manifest) This PR should not be merged (controlled by action-manifest) Binary Blobs Added labels Sep 19, 2025

smalae requested a review from jerome-pouiller September 19, 2025 06:24

asmellby reviewed Sep 19, 2025

View reviewed changes

smalae added 4 commits September 19, 2025 16:12

drivers: serial: uart_ns16550: Add pm support for uart_ns16550 driver

092baed

This commit enables the pm device runtime driver support for the uart_ns16550 driver (only for devices that have an associated power domain enabled). Signed-off-by: Sai Santhosh Malae <[email protected]>

modules: hal_silabs: Remove CMSIS references

15d7c37

Removed CMSIS references from wiseconnect CMakeLists as they are no longer required with UART device runtime PM. Keeping them adds unnecessary compilation overhead. Signed-off-by: Sai Santhosh Malae <[email protected]>

west.yml: Update hal_silabs version

a490bcb

Update hal_silabs version to latest commit: edbd418670ad8c7cad629a09df2ceee0bc23cf6d Signed-off-by: Sai Santhosh Malae <[email protected]>

smalae force-pushed the device-runtime-support-for-uart_ns16550-and-power-domain-support-for-siwx91x-soc branch from 2cb5f60 to a490bcb Compare September 19, 2025 10:46

zephyrbot added the area: Power Management label Sep 19, 2025

zephyrbot requested review from ceolin, JordanYates, nashif, teburd and tmleman September 19, 2025 10:48

smalae requested a review from asmellby September 19, 2025 10:51

asmellby approved these changes Sep 19, 2025

View reviewed changes

jhedberg approved these changes Sep 19, 2025

View reviewed changes

dcpleung approved these changes Sep 19, 2025

View reviewed changes

fabiobaltieri approved these changes Sep 19, 2025

View reviewed changes

Device runtime support for uart ns16550 and power domain support for siwx91x soc #94851

Are you sure you want to change the base?

Device runtime support for uart ns16550 and power domain support for siwx91x soc #94851

Uh oh!

Conversation

smalae commented Aug 22, 2025

Uh oh!

github-actions bot commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smalae commented Aug 25, 2025

Uh oh!

bjarki-andreasen left a comment

Choose a reason for hiding this comment

Uh oh!

bjarki-andreasen Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

smalae Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

smalae Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

fabiobaltieri Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

smalae Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

smalae commented Sep 18, 2025

Uh oh!

jerome-pouiller Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

smalae Sep 19, 2025

Choose a reason for hiding this comment

Uh oh!

jhedberg commented Sep 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhedberg commented Sep 19, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 19, 2025

Quality Gate passed

Uh oh!

fabiobaltieri left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Aug 22, 2025 •

edited

Loading

jerome-pouiller Sep 18, 2025 •

edited

Loading

jhedberg commented Sep 18, 2025 •

edited

Loading

fabiobaltieri left a comment •

edited

Loading