Skip to content

dts: arm: st: stm32g4: add quadspi node #93511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dts: arm: st: stm32g4: add quadspi node #93511

wants to merge 1 commit into from

Conversation

schmida2
Copy link
Contributor

The STM32G4 variants g473, g474, g483, g484, g491 and g4a1 do support QuadSPI interface. All mentioned variants include the stm32g491.dtsi.

@github-actions GitHub Actions
Copy link

Hello @schmida2, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Jul 22, 2025
erwango
erwango reviewed Jul 22, 2025
View reviewed changes
FRASTM
FRASTM reviewed Jul 22, 2025
View reviewed changes
dts/arm/st/g4/stm32g491.dtsi
@@ -77,5 +77,15 @@
interrupts = <53 0>;
status = "disabled";
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be included in the stm32g4.dtsi, the quadspi node is present in all the series

Copy link
Contributor Author

@schmida2 schmida2 Jul 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FRASTM, per my understanding stm32g431 and stm32g441 have no quadspi.

@schmida2
dts: arm: st: stm32g4: add quadspi node
795a018 
The STM32G4 variants g473, g474, g483, g484, g491 and g4a1 do support QSPI
interface. All mentioned variants include the stm32g491.dtsi.

Signed-off-by: Andreas Schmidt <[email protected]>
schmida2 referenced this pull request Jul 23, 2025
@TDhaouST @MaureenHelm
dts/arm/st: g4: device tree factorization
1135796 
dts files in G4 series could use some factorization

Signed-off-by: TLIG Dhaou <[email protected]>
erwango
erwango previously approved these changes Jul 23, 2025
View reviewed changes
erwango
erwango requested changes Jul 23, 2025
View reviewed changes
dts/arm/st/u5/stm32u5_extra.dtsi Outdated
Comment on lines 84 to 85
<&gpioa 7 STM32_PWR_WKUP_EVT_SRC_1>,
<&gpiob 10 STM32_PWR_WKUP_EVT_SRC_2>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix indentation.
(Note, zephyr defines tabs as 8 chars lenght)

Copy link
Contributor Author

@schmida2 schmida2 Jul 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check formatting, thanks.
BTW, @erwango, I am new to github contributions; I was not planning to mix both topics (DTS changes for stm32g4 and stm32u5) in this PR. I separated them; stm32u5 PR is this now: #93577

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@schmida2 schmida2 requested a review from erwango July 23, 2025 11:36
@schmida2 schmida2 requested a review from FRASTM July 23, 2025 11:40
@schmida2
Copy link
Contributor Author

@erwango , I feel not guilty for the 3 failing checks (twister). Do you know what the background is?

@erwango
Copy link
Member

erwango commented Jul 25, 2025

@erwango , I feel not guilty for the 3 failing checks (twister). Do you know what the background is?

I've forced them to re-run, it is good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

@etienne-lms etienne-lms Awaiting requested review from etienne-lms

@gautierg-st gautierg-st Awaiting requested review from gautierg-st

@GeorgeCGV GeorgeCGV Awaiting requested review from GeorgeCGV

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@mathieuchopstm mathieuchopstm Awaiting requested review from mathieuchopstm

@FRASTM FRASTM Awaiting requested review from FRASTM

At least 2 approving reviews are required to merge this pull request.

Assignees

@erwango erwango

Labels
platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schmida2 @erwango @FRASTM @zephyrbot