Skip to content

Conversation

janchri
Copy link
Contributor

@janchri janchri commented Jul 17, 2025

This PR adds support for two development kits from Silicon Labs:

  • PG23-PK2504A
  • PG28-PK2506A

For the PG23-PK2504A, RTT has been configured due to issues when accessing the console via EUSART0/1. Tested manually on basic samples (hello world, blinky, and button).

This PR builds on the work carried out for xg24_ek2703a and other ports from the dev Kit folder.

Depends on: zephyrproject-rtos/hal_silabs#95

Copy link

Hello @janchri, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link

github-actions bot commented Jul 17, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_silabs zephyrproject-rtos/hal_silabs@190a144 zephyrproject-rtos/hal_silabs@95e9574 (main) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_silabs DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Jul 17, 2025
@janchri janchri force-pushed the tmp_rebase branch 2 times, most recently from c557aae to 1f89892 Compare July 18, 2025 15:38
@janchri janchri requested a review from nordicjm July 18, 2025 15:45
@janchri janchri force-pushed the tmp_rebase branch 2 times, most recently from 0eae543 to dcf914d Compare July 19, 2025 22:47
@janchri
Copy link
Contributor Author

janchri commented Jul 21, 2025

Thank a lot for the feedback @asmellby

@janchri janchri requested a review from jerome-pouiller August 1, 2025 12:27
asmellby
asmellby previously approved these changes Aug 1, 2025
jerome-pouiller
jerome-pouiller previously approved these changes Aug 1, 2025
If no serial output occurs, use SEGGERs RTT Viewer and update :zephyr_file:`boards/silabs/dev_kits/pg23_pk2504a/pg23_pk2504a_defconfig` with

.. code-block:: console
CONFIG_UART_CONSOLE=n
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation build fails due to lack of indentation here, same for pg28.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think your latest change did what you wanted it to:
image

While the error message complained about a missing newline, indentation was also missing to make the options part of the code block.

@janchri janchri dismissed stale reviews from jerome-pouiller and asmellby via 659fa2c August 1, 2025 14:28
@janchri janchri force-pushed the tmp_rebase branch 2 times, most recently from 659fa2c to 3ce8376 Compare August 1, 2025 16:29
@janchri janchri requested a review from yishai1999 August 1, 2025 16:30
Copy link

sonarqubecloud bot commented Aug 1, 2025

Adding pg23_pk2504a and pg28_pk2506a boards files.

Signed-off-by: Christoph Jans <[email protected]>
Comment on lines +70 to +72
The default configuration can be found in
:zephyr_file:`boards/silabs/dev_kits/pg28_pk2506a/pg28_pk2506a_defconfig`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this can go @kartben ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, the board "card" summary already conveniently links to the board's source folder on GitHub where folks can easily find defconfig files

@nordicjm nordicjm requested a review from kartben August 4, 2025 07:12
@fabiobaltieri fabiobaltieri merged commit f437ba4 into zephyrproject-rtos:main Aug 4, 2025
27 checks passed
Copy link

github-actions bot commented Aug 4, 2025

Hi @janchri!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@janchri janchri deleted the tmp_rebase branch August 5, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.