NXP S32 introduce support SENT #80117

congnguyenhuu · 2024-10-21T03:49:44Z

Introduce support Single Edge Nibble Transmission (SENT) driver using peripheral SENT receiver on S32Z. This driver allows to communication (read data) with SENT device.
The test result: SENT-RECEIVER-TESTING-RESULT.pptx

RFC: #83983

zephyrbot · 2024-10-21T03:50:42Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
hal_nxp	zephyrproject-rtos/hal_nxp@`111f568`	zephyrproject-rtos/hal_nxp@`fc8aa27` (`master`)	zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

manuargue · 2024-11-22T04:26:59Z

@congnguyenhuu I'd suggest you to open an RFC (request for comments) and link it to this pr in order to involve community to review the proposal and reach consensus: https://docs.zephyrproject.org/latest/contribute/proposals_and_rfcs.html

dleach02 · 2025-06-25T17:24:13Z

close/reopen to clear false bot block

Copilot

Pull Request Overview

This PR introduces support for the Single Edge Nibble Transmission (SENT) driver on NXP S32Z devices, including a new driver implementation, device tree bindings, test cases, samples, and documentation updates.

Added NXP S32 SENT receiver driver and API (drivers/sent/…)
Introduced DTS bindings and board overlays for SENT controllers and channels
Added tests (tests/drivers/sent/…), sample application (samples/drivers/sent/…), and documentation

Reviewed Changes

Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.

File	Description
drivers/sent/sent_nxp_s32.c	New NXP S32 SENT driver source implementation
include/zephyr/drivers/sent/sent.h	SENT public API headers
dts/bindings/sent/sent-controller.yaml	Device tree binding for SENT controller
tests/drivers/sent/sent_api/src/main.c	API test cases for start/stop/register

Comments suppressed due to low confidence (3)

tests/drivers/sent/sent_api/src/main.c:105

The tests verify callback registration but do not exercise actual frame reception or callback invocation. Consider adding a mock or simulated SENT frame to validate the user callback path.

	err = sent_register_callback(sent_dev, SENT_CHANNEL, callback_configs);

drivers/sent/sent_nxp_s32.c:366

[nitpick] The term channel_map may be misleading since it holds hardware register addresses. Consider renaming to channel_hw_offsets or adding a clarifying comment.

		.channel_map = {DT_INST_FOREACH_CHILD_STATUS_OKAY_SEP(n, DT_REG_ADDR, (,))},       \

doc/hardware/peripherals/sent.rst:17

[nitpick] The documentation lists only the generic CONFIG_SENT option. It could be helpful to reference the NXP S32-specific driver (e.g., CONFIG_SENT_NXP_S32) and point to the sample application.

* :kconfig:option:`CONFIG_SENT`

tests/drivers/sent/sent_api/src/main.c

kartben · 2025-06-26T02:40:10Z

dts/bindings/sent/sent-controller.yaml

+#
+# SPDX-License-Identifier: Apache-2.0
+
+description: Single Edge Nibble Transmission (SENT) Controller


Suggested change

description: Single Edge Nibble Transmission (SENT) Controller

description: SENT (Single Edge Nibble Transmission) Controller

kartben · 2025-06-26T02:40:58Z

dts/bindings/sent/nxp,s32-sent.yaml

+#
+# SPDX-License-Identifier: Apache-2.0
+
+description: NXP S32 Single Edge Nibble Transmission (SENT) Receiver Controller


Suggested change

description: NXP S32 Single Edge Nibble Transmission (SENT) Receiver Controller

description: NXP S32 SENT (Single Edge Nibble Transmission) Receiver Controller

kartben · 2025-06-26T02:42:04Z

include/zephyr/drivers/sent/sent.h

+	SENT_SHORT_SERIAL_FRAME,
+	SENT_ENHANCED_SERIAL_FRAME_4_BIT_ID,
+	SENT_ENHANCED_SERIAL_FRAME_8_BIT_ID,
+	SENT_FAST_FRAME


Enum fields need Doxygen docs

kartben · 2025-06-26T02:43:21Z

include/zephyr/drivers/sent/sent.h

+	enum sent_frame_type type;
+
+	union {
+		struct {
+			uint8_t id;
+			uint16_t data;
+		} serial;
+
+		struct {
+			uint8_t data_nibbles[SENT_MAX_DATA_NIBBLES];
+		} fast;
+	};
+
+	uint32_t timestamp;
+	uint8_t crc;


Missing Doxygen docs or mark as INTERNAL_HIDDEN if it's meant to be an opaque type from an API standpoint

I updated to add doxygen

kartben · 2025-06-26T02:43:58Z

include/zephyr/drivers/sent/sent.h

+	sent_rx_frame_callback_t callback;
+	struct sent_frame *frame;
+	uint32_t max_num_frame;
+	void *user_data;


Missing docs

kartben · 2025-06-26T02:46:38Z

include/zephyr/drivers/sent/sent.h

+ * @retval 0 if successful.
+ * @retval -EINVAL if an invalid channel is given.


Suggested change

* @retval 0 if successful.

* @retval -EINVAL if an invalid channel is given.

* @retval 0 success.

* @retval -EINVAL invalid channel.

kartben · 2025-06-26T02:47:12Z

include/zephyr/dt-bindings/sent/sent.h

+#define FAST_CRC_DISABLE 0
+#define FAST_CRC_LEGACY_IMPLEMENTATION 1
+#define FAST_CRC_RECOMMENDED_IMPLEMENTATION 2
+#define FAST_CRC_STATUS_INCLUDE 4
+
+#define SHORT_CRC_LEGACY_IMPLEMENTATION 0
+#define SHORT_CRC_RECOMMENDED_IMPLEMENTATION 1


Missing Doxygen comments

kartben · 2025-06-26T02:48:34Z

samples/drivers/sent/README.rst

+Overview
+********
+
+The sample application shows how to use the Single Edge Nibble Transmission (SENT) driver:


Make "SENT (...)" a link to the SENT doc page

kartben · 2025-06-26T02:49:41Z

samples/drivers/sent/README.rst

+Requirements
+************
+
+This sample requires a SENT sensor to be connected.


Suggested change

This sample requires a SENT sensor to be connected.

This sample requires a SENT sensor to be connected and exposed as ``sent-node`` Devicetree alias.

I updated to This sample requires a SENT sensor to be connected and exposed as ``sent0`` Devicetree alias.

kartben · 2025-06-26T02:51:09Z

samples/drivers/sent/boards/s32z2xxdc2_s32z270_rtu0.overlay

+
+/ {
+	aliases {
+		sent-node = &sent1;


It's a bit unconventional to use the -node suffix here IMO. Convention would be to call this sent0, I think.

I updated to call sent0

kartben · 2025-06-26T03:23:52Z

tests/drivers/sent/sent_api/src/main.c

+	zassert_equal(err, 0, "Failed to start rx (err %d)", err);
+
+	err = sent_start_listening(sent_dev, SENT_CHANNEL);
+	zassert_not_equal(err, 0, "Started rx while started");


I would suggest using z_assert_ok() / z_assert_not_ok() instead for all these kinds of asserts

congnguyenhuu · 2025-06-26T10:56:28Z

twister-build is failing, it fixes by PR #92238

This driver allows to communication (receive data) with SENT device Signed-off-by: Cong Nguyen Huu <[email protected]>

enable support SENT Signed-off-by: Cong Nguyen Huu <[email protected]>

Create test, sample for SENT driver Signed-off-by: Cong Nguyen Huu <[email protected]>

sonarqubecloud · 2025-06-26T16:55:34Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

kartben

Great work with the docs, much appreciated!

kartben

Great work with the docs, much appreciated!

zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 21, 2024

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 4 times, most recently from ec62630 to b483917 Compare October 28, 2024 03:29

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 3 times, most recently from d00b883 to 23b01d3 Compare November 1, 2024 02:24

congnguyenhuu marked this pull request as ready for review November 22, 2024 03:42

congnguyenhuu requested a review from manuargue as a code owner November 22, 2024 03:42

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 23b01d3 to 55d6a35 Compare November 22, 2024 03:42

zephyrbot added platform: NXP S32 NXP Semiconductors, S32 area: Samples Samples labels Nov 22, 2024

zephyrbot requested review from bperseghetti, Dat-NguyenDuy, kartben, nashif and PetervdPerk-NXP November 22, 2024 03:43

zephyrbot assigned manuargue Nov 22, 2024

congnguyenhuu marked this pull request as draft November 22, 2024 04:32

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from 55d6a35 to ec00dc8 Compare December 4, 2024 07:52

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch 5 times, most recently from c79ca4d to f2e3c0c Compare January 7, 2025 01:54

danieldegrasse previously approved these changes Jun 25, 2025

View reviewed changes

dleach02 closed this Jun 25, 2025

dleach02 reopened this Jun 25, 2025

dleach02 previously approved these changes Jun 25, 2025

View reviewed changes

Dat-NguyenDuy previously approved these changes Jun 26, 2025

View reviewed changes

kartben requested review from Copilot and removed request for KarstenBade June 26, 2025 02:31

Copilot AI reviewed Jun 26, 2025

View reviewed changes

tests/drivers/sent/sent_api/src/main.c Outdated Show resolved Hide resolved

kartben requested changes Jun 26, 2025

View reviewed changes

kartben reviewed Jun 26, 2025

View reviewed changes

congnguyenhuu dismissed stale reviews from Dat-NguyenDuy, dleach02, danieldegrasse, manuargue, and mmahadevan108 via b49122f June 26, 2025 08:38

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from e069738 to b49122f Compare June 26, 2025 08:38

congnguyenhuu added 3 commits June 26, 2025 23:11

drivers: introduce Single Edge Nibble Transmission (SENT) driver

6c7f154

This driver allows to communication (receive data) with SENT device Signed-off-by: Cong Nguyen Huu <[email protected]>

boards: s32z270: enable support SENT

2e62bfb

enable support SENT Signed-off-by: Cong Nguyen Huu <[email protected]>

tests/samples: drivers: create test, sample for SENT driver

d1d740a

Create test, sample for SENT driver Signed-off-by: Cong Nguyen Huu <[email protected]>

congnguyenhuu force-pushed the nxp-s32-introduce-support-sent branch from b49122f to d1d740a Compare June 26, 2025 16:14

dleach02 approved these changes Jun 26, 2025

View reviewed changes

kartben approved these changes Jun 26, 2025

View reviewed changes

Dat-NguyenDuy approved these changes Jun 27, 2025

View reviewed changes

manuargue approved these changes Jun 27, 2025

View reviewed changes

dkalowsk merged commit 1a3f46c into zephyrproject-rtos:main Jun 27, 2025
34 checks passed

manuargue deleted the nxp-s32-introduce-support-sent branch June 27, 2025 05:01

	description: Single Edge Nibble Transmission (SENT) Controller
	description: SENT (Single Edge Nibble Transmission) Controller

	description: NXP S32 Single Edge Nibble Transmission (SENT) Receiver Controller
	description: NXP S32 SENT (Single Edge Nibble Transmission) Receiver Controller

		* @retval 0 if successful.
		* @retval -EINVAL if an invalid channel is given.

	This sample requires a SENT sensor to be connected.
	This sample requires a SENT sensor to be connected and exposed as ``sent-node`` Devicetree alias.

NXP S32 introduce support SENT #80117

NXP S32 introduce support SENT #80117

Uh oh!

Conversation

congnguyenhuu commented Oct 21, 2024 • edited by Dat-NguyenDuy Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Oct 21, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manuargue commented Nov 22, 2024

Uh oh!

dleach02 commented Jun 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

congnguyenhuu Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kartben Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

congnguyenhuu commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jun 26, 2025

Quality Gate passed

Uh oh!

kartben left a comment

Choose a reason for hiding this comment

congnguyenhuu commented Oct 21, 2024 •

edited by Dat-NguyenDuy

Loading

zephyrbot commented Oct 21, 2024 •

edited by github-actions bot

Loading

kartben Jun 26, 2025 •

edited

Loading

congnguyenhuu Jun 26, 2025 •

edited

Loading

kartben Jun 26, 2025 •

edited

Loading

congnguyenhuu commented Jun 26, 2025 •

edited

Loading