picolib: Add stdc++ noexcept variant #863
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adigie
force-pushed
the
picolib-noexcept
branch
from
b383e29 to
ac61ef1
Compare
| @@ -1,6 +1,6 @@ | |||
| [submodule "crosstool-ng"] | |||
| path = crosstool-ng | |||
| url = https://github.com/zephyrproject-rtos/crosstool-ng.git | |||
| url = https://github.com/adigie/crosstool-ng.git | |||
There was a problem hiding this comment.
Could we make this use the same picolibcpp.specs file and just replace -lstdc++ with -lstdc++-noexcept? Do we need different header paths or something?
There was a problem hiding this comment.
I was thinking about doing something similar to Newlib nano, but it would probably be easier to keep the same specs file for all configurations.
I made a change in Zephyr to link proper variant: zephyrproject-rtos/zephyr/pull/85945
Is this what you had in mind?
adigie
force-pushed
the
picolib-noexcept
branch
4 times, most recently
from
4d056b5 to
30ff1ee
Compare
Signed-off-by: Adrian Gielniewski <[email protected]>
adigie
force-pushed
the
picolib-noexcept
branch
from
30ff1ee to
5bc997c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile additional variant of libstdc++ with exceptions disabled.
crosstool-ng PR: zephyrproject-rtos/crosstool-ng/pull/32
Fixes #860