nrfs: Added explicit enum values #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added explicit enum values for better resistance to change Signed-off-by: Rafal Dyla <[email protected]>
Rafal-Nordic
force-pushed
the
Explicit_enum_values
branch
from
f512db3 to
d9f5f74
Compare
|
There still is a lot missing in the other ones I think assigning fixed enums everywhere will greatly reduce the chance of accidental breakage, when enums are hardcoded people tend to make sure to not insert in the middle or reorder, when they are not it seems the order doesn't matter and one needs to be very careful during reviews to catch enums changing sequence that need to have compatibility kept in mind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explicit enum values for better resistance to change