Skip to content

zephyrCommon: Implement pulseIn #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2024
Merged

zephyrCommon: Implement pulseIn #101

merged 1 commit into from
Jun 19, 2024

Conversation

Ayush1325
Copy link
Member

@Ayush1325 Ayush1325 commented Jun 8, 2024 •
edited
Loading

  • A basic sync implementation

@Ayush1325 Ayush1325 mentioned this pull request Jun 9, 2024
Open
6 tasks
@Ayush1325 Ayush1325 force-pushed the pulsein branch 2 times, most recently from bd94398 to 96b6e8a Compare June 10, 2024 10:47
DhruvaG2000
DhruvaG2000 requested changes Jun 13, 2024
View reviewed changes
@Ayush1325 Ayush1325 force-pushed the pulsein branch 3 times, most recently from bc4ecbc to 3baf23b Compare June 14, 2024 16:40
DhruvaG2000
DhruvaG2000 requested changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@DhruvaG2000 DhruvaG2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, with the minor suggestions we should be ok.

@Ayush1325
Copy link
Member Author

Ayush1325 commented Jun 19, 2024 •
edited
Loading

@DhruvaG2000 Any idea regarding the failing CI? I don't think it is related to this PR.

@DhruvaG2000
Copy link
Collaborator

@DhruvaG2000 Any idea regarding the failing CI?

Yep, locally reproduced just now.
/__w/gsoc-2022-arduino-core/gsoc-2022-arduino-core/Arduino-Zephyr-API/samples/i2cdemo/prj.conf:2: warning: attempt to assign the value 'y' to the undefined symbol CPLUSPLUS

Need to get rid of this symbol from everywhere looks like.

@DhruvaG2000
Copy link
Collaborator

Not related to this PR, so nothing to be alarmed.

@DhruvaG2000
Copy link
Collaborator

This PR should probably help:
#104

@Ayush1325
zephyrCommon: Implement pulseIn
a95211f 
- A basic sync implementation
- Use ticks for better resolution

Signed-off-by: Ayush Singh <[email protected]>
@DhruvaG2000 DhruvaG2000 merged commit 3674743 into zephyrproject-rtos:next Jun 19, 2024
2 checks passed
@Ayush1325 Ayush1325 deleted the pulsein branch June 19, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathieuchopstm mathieuchopstm mathieuchopstm left review comments

@DhruvaG2000 DhruvaG2000 DhruvaG2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ayush1325 @DhruvaG2000 @mathieuchopstm