fix: remove uncessary error tracking

[jiashengguo]

Summary by CodeRabbit

• Bug Fixes

  • Improved error handling to properly propagate errors in configuration loading scenarios.

• Documentation

  • Clarified error message guidance for missing datasource URL configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes telemetry tracking invocations from error handling paths in the entry point and broadens error rethrow logic in the configuration parser to catch all Error instances rather than filtering by message content. An error message guidance string is also slightly refined.

Changes

Cohort / File(s)	Summary
Telemetry removal src/index.ts	Removed three telemetry.trackError() calls from error handling branches (CliError, Error, and non-Error cases). Error reporting now relies solely on console.error.
Error handling refinement src/zmodel-parser.ts	Expanded error rethrow condition in loadPrismaConfig catch block to rethrow all Error instances instead of selectively rethrowing only those containing "Environment variable" in the message. Updated error guidance message in parseDatasource for clarity.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: improve error handling in datasource URL parsing #18: Modifies the same error-handling logic in loadPrismaConfig and parseDatasource functions within src/zmodel-parser.ts
• fix: enhance error tracking for unhandled exceptions and datasource U… #19: Makes opposing changes to telemetry tracking in src/index.ts and error rethrow behavior in src/zmodel-parser.ts
• fix: shows v3 not supported message #17: Alters related error-handling and parsing logic across both src/zmodel-parser.ts and src/index.ts with similar structural modifications

Poem

🐰 With whiskers twitched and nose in code,
I hopped through errors on this road,
Telemetry calls we bid adieu,
Broader catches—simpler, true!
The parser cleaned, the messages bright,
This rabbit's work done just right! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d3af1ad and e483112.

📒 Files selected for processing (2)

• src/index.ts
• src/zmodel-parser.ts

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR removes redundant error tracking calls and improves error handling and messaging. The changes simplify error handling logic by removing duplicate telemetry tracking and refining conditional checks.

Changes:

• Removed duplicate telemetry.trackError() calls in error handlers since errors are already tracked by trackSpan() wrapper
• Simplified error handling condition in loadPrismaConfig() to throw all Error instances
• Improved clarity of datasource URL error message

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/index.ts	Removed three redundant telemetry.trackError() calls from error handling blocks
src/zmodel-parser.ts	Simplified error handling condition and improved error message wording

Comments suppressed due to low confidence (1)

src/index.ts:1

• Corrected spelling of 'uncessary' to 'unnecessary' in PR title.

#!/usr/bin/env node

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This change removes the specific check for 'Environment variable' errors, causing all Error instances to be re-thrown. This means any error during config parsing (like syntax errors) will now crash the application instead of logging a warning and returning null. The original logic allowed graceful fallback for non-environment-variable errors. Consider keeping the specific error message check or using a custom error type for environment variable errors to maintain the fallback behavior.

Suggested change

	if (error instanceof Error) {
	if (error instanceof CliError && typeof error.message === 'string' && error.message.startsWith('Environment variable')) {
	// Propagate environment-variable-related configuration errors