add extensions tab, improve visibility#124
Conversation
Signed-off-by: alexvoss <alex@corealization.com>
pawamoy
left a comment
pawamoy
left a comment
There was a problem hiding this comment.
Nice 👌
I think the split between Theme and Site settings makes it much easier to parse 👍
|
@pawamoy thanks for reviewing - I did not mean to ask you to, so either you volunteered (thumbs up) or I had fat fingers (apologies). Either way, great that you like the changes! |
|
I'm "watching all activity" on the repo, so I got the notification, no fat fingers 😄 |
| - Comment system: setup/comment-system.md | ||
| - Offline usage: setup/offline.md | ||
| - Extensions: | ||
| - setup/extensions/index.md |
There was a problem hiding this comment.
When you select the Extensions tab you land on a page that doesn't appear in the left nav. Is that intentional? All the other tabs land on a page that appears in that tab's left nav.
There was a problem hiding this comment.
Not intentional, just happens because the extensions section has an index.md page and the other tabs do not. We could rename the page to about.md and give it a navigation title and an icon. That would make it consistent across the different tabs.
| existing content when the time comes. | ||
| comprehensive module system that will allow us to support CommonMark and | ||
| components in the future. Of course, we will provide tools to automatically | ||
| migrate your existing content when the time comes. |
There was a problem hiding this comment.
The CommonMark support is to replace Python Markdown? There is no longer a mention of Python Markdown prior to this, so I think it would be helpful to provide more context and maybe a link out to where it's discussed in more detail.
There was a problem hiding this comment.
I think I have a way to re-arrange the words.
…mmonMark Signed-off-by: alexvoss <alex@corealization.com>
3 participants
This PR pulls out Markdown extensions from the setup section. This serves both to make them more visible and the de-clutter that section. The extensions index page will now be more visible as it is what people naturally click on when they select the tab.
In the longer term, this might be where we need to distinguish between Python Markdown extensions on the one hand and components on the other. We may then want to re-visit the labeling.
The navigation in Setup is now split into two sections. @LiamConnors raised the question what the logic of the ordering is and defining sections is a first attempt to improve this.