Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent capitalisation and remove invalid attribute #1119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carlinmack
Copy link
Contributor

@carlinmack carlinmack commented Feb 3, 2025

  1. Capitalised the first word always after —

  2. Removed full stop at end of sentence as it is unnecessary

  3. I know I shouldn't put this in the same PR (I used the web UI sorry), but removed the checked attributed as it is invalid on type=hidden elements. I did test that you can still subscribe to the mailing list when checked is removed

image

@slint
Copy link
Member

slint commented Feb 11, 2025

Test comment

Copy link
Member

@ptamarit ptamarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced that uppercase and no dot is the best option, but at least this makes it consistent.

@carlinmack
Copy link
Contributor Author

Wikipedia does endorse the full stop, for me it's not necessary in this context

https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Lists#Format_list_items_consistently

image

Think I prefer lowercase but I wanted to follow the status quo

Copy link
Contributor

@jrcastro2 jrcastro2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed with @0einstein0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants