Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Improve curry performances #317

Merged
merged 9 commits into from
Dec 10, 2018
Merged

Improve curry performances #317

merged 9 commits into from
Dec 10, 2018

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Nov 30, 2018

Issue : fix #316

@codecov-io
Copy link

codecov-io commented Nov 30, 2018

Codecov Report

Merging #317 into dev will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #317      +/-   ##
==========================================
+ Coverage   96.81%   97.17%   +0.35%     
==========================================
  Files         107      107              
  Lines         377      425      +48     
==========================================
+ Hits          365      413      +48     
  Misses         12       12
Impacted Files Coverage Δ
packages/immutadot/src/core/curry.js 100% <100%> (ø) ⬆️
packages/immutadot/src/core/apply.js 59.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 044e06b...1d4558e. Read the comment docs.

@nlepage
Copy link
Member Author

nlepage commented Nov 30, 2018

Some explanation:
fixedArity's only purpose is performance.
It might or might not truncate extra arguments.
So no assumption should be made on whether extra arguments will or will not be truncated.
To be honest, I tried implementing a consistent behavior (truncating args when fixedArity is true and all args are sent at once, using args.slice(0, arity)), but it had significant impact on performance...

@nlepage
Copy link
Member Author

nlepage commented Nov 30, 2018

Results here: #299 (comment)

@nlepage nlepage removed the 🚧 WIP label Dec 1, 2018
@nlepage nlepage self-assigned this Dec 3, 2018
@nlepage nlepage merged commit 27b9903 into dev Dec 10, 2018
@nlepage nlepage deleted the enhance/316 branch December 10, 2018 09:31
nlepage added a commit that referenced this pull request Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants