-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: testing upcoming useMenu
fix [ DO NOT MERGE ⚠️ ]
#2011
base: main
Are you sure you want to change the base?
Conversation
@ze-flo I know it's a pain, but given the potential pitfalls with this change, it might be good to throw a similar PR at the |
I noticed that testing the fix using the Website demos has a limitation: since everything renders in the top window, it doesn't let us verify how the Menu behaves when focus moves to another frame. To more accurately simulate the AdminX environment and better test the dropdown’s behavior when focus changes, I added the Website Menu examples to Storybook, which renders stories in an iframe. I ran through all the stories, and the focus behavior and dropdown handling looked solid — no issues found. 💯 😌 |
Testing the website is less about ensuring iframes work and more about ensuring the change offers exact parity with the existing |
Description
Testing and demo'ing the
Menu
component'sonBlur
behavior with the upcoming bug fix touseMenu
.DO NOT MERGE!⚠️