Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing upcoming useMenu fix [ DO NOT MERGE ⚠️ ] #2011

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ze-flo
Copy link
Contributor

@ze-flo ze-flo commented Mar 27, 2025

Description

Testing and demo'ing the Menu component's onBlur behavior with the upcoming bug fix to useMenu.

DO NOT MERGE! ⚠️

@jzempel
Copy link
Member

jzempel commented Mar 27, 2025

@ze-flo I know it's a pain, but given the potential pitfalls with this change, it might be good to throw a similar PR at the website and the Menu examples there.

@ze-flo
Copy link
Contributor Author

ze-flo commented Mar 28, 2025

@ze-flo I know it's a pain, but given the potential pitfalls with this change, it might be good to throw a similar PR at the website and the Menu examples there.

I noticed that testing the fix using the Website demos has a limitation: since everything renders in the top window, it doesn't let us verify how the Menu behaves when focus moves to another frame.

To more accurately simulate the AdminX environment and better test the dropdown’s behavior when focus changes, I added the Website Menu examples to Storybook, which renders stories in an iframe.

I ran through all the stories, and the focus behavior and dropdown handling looked solid — no issues found. 💯 😌

@jzempel
Copy link
Member

jzempel commented Mar 28, 2025

I noticed that testing the fix using the Website demos has a limitation: since everything renders in the top window, it doesn't let us verify how the Menu behaves when focus moves to another frame.

Testing the website is less about ensuring iframes work and more about ensuring the change offers exact parity with the existing Menu examples

@ze-flo
Copy link
Contributor Author

ze-flo commented Apr 4, 2025

@ze-flo I know it's a pain, but given the potential pitfalls with this change, it might be good to throw a similar PR at the website and the Menu examples there.

Check out the Website examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants