Inject script in footer if theme is using theming v2 api #340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✌️
/cc @zendesk/vegemite
Description
As mentioned in #339
The theme preview is injecting script.js in document_head template which was fine for theming_v1 based themes.
The theming_v2 themes will now have script.js at the end of the page. That means, people need to do some work to migrate their javascript to adopt to this new situation (script.js loads at the end), and test.
This must be fixed to make sure we can have similar (if not same) locally. The order of script matters a lot, and if it's not right it leads to issues.
I have made the change to check api_version, and change the template where script is injected.
Tasks
References
Risks