Update CKEditor to the latest version #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ef057f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fredx87
force-pushed
the
gianluca/GG-4331/update-ckeditor
branch
2 times, most recently
from
6f7634f to
c302125
Compare
Fredx87
commented
Oct 21, 2025
| process.env.NODE_ENV === "production" | ||
| ? process.env.CKEDITOR_LICENSE_KEY_PRODUCTION | ||
| : process.env.CKEDITOR_LICENSE_KEY_DEVELOPMENT, | ||
| : process.env.CKEDITOR_LICENSE_KEY_DEVELOPMENT || "GPL", |
Contributor
Author
There was a problem hiding this comment.
This is needed since licenseKey is mandatory from v44: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-44.html#required-license-key-configuration.
With this fallback, anybody can run yarn start to launch the dev mode without the need to specify a license. For the production build, we always want to use a proper key instead
BrunoBFerreira
approved these changes
Oct 24, 2025
Fredx87
force-pushed
the
gianluca/GG-4331/update-ckeditor
branch
from
c302125 to
cf44550
Compare
This package is built as a UMD bundle, so none of its dependencies are required at runtime.
…nipulation With the new versions of CKEditor, the method used to convert the mention elements between the view and data formats has stopped working. This commit refactors the MentionsDataProcessor to use the proper CKEditor API for manipulating view elements, specifically the ViewUpcastWriter class.
Fredx87
force-pushed
the
gianluca/GG-4331/update-ckeditor
branch
from
cf44550 to
1ef057f
Compare
BrunoBFerreira
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CKEditor to the latest available version (v47.2.0). This brings in the latest improvement and bug fixes, and it fixes the reported security vulnerabilities (even if they are related to plugins we are not using).
It is worth noting that CKEditor v47 is the first LTS release: https://ckeditor.com/docs/ckeditor5/latest/updating/guides/update-to-47.html#long-term-support. I am not sure if our license covers LTS, but it will come in handy in the future in case we want to migrate to a still-supported version without breaking changes.
Main changes:
main.jsfile, and the consumer of this package doesn't need to install them.CommunityMentionsPluginMentionsDataProcessorclass that was not working anymore, using different APIs to manipulate the elementsI set the changeset to release a major version. The package has been around for a while, and we are still at version
0.1.1. I think it is time to release a properv1.0.0.[Jira issue] https://zendesk.atlassian.net/browse/GG-4331
[Z2] https://support.zendesk.com/agent/tickets/13528906