Skip to content

Don't include extra whitespace in compiled text #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't include extra whitespace in compiled text #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/curly/compiler.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,9 @@ def compile_component(component)
end

def compile_text(text)
output "buffer.safe_concat(#{text.value.inspect})"
if non_whitespace_text = text.value.presence
output "buffer.safe_concat(#{non_whitespace_text.inspect})"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would remove indentional whitespace as well, right?

{{one}}   {{two}}   {{three}}

There may be a reason for the whitespace, e.g. when sending plain text emails.

end
end

def compile_comment(comment)
Expand Down
7 changes: 7 additions & 0 deletions spec/compiler_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ def method_missing(*args)
evaluate("test{{^false?}}bar{{/false?}}").should == "testbar"
end

it "removes extra whitespace from the output" do
presenter.stub(:foo) { "" }
template = "{{^false?}}\n{{foo}}\n<a href='bar'>bar</a>\n{{foo}}\n{{/false?}}\n"

evaluate(template).should == "\n<a href='bar'>bar</a>\n"
end

it "passes an argument to blocks" do
evaluate("{{#hello.world?}}foo{{/hello.world?}}{{#hello.foo?}}bar{{/hello.foo?}}").should == "foo"
end
Expand Down