Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts for Next/Prev Tab Navigation #3599

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

normaltaro
Copy link

@normaltaro normaltaro commented Dec 11, 2024

Added 2 shortcuts for tab navigation.

  1. Switching to Next Tab (Unbounded by default)
  2. Switching to Previous Tab (Unbounded by default)

Using extensions such as Tridactyl or Vimium to do this stops working on protected pages such as New Tab, Settings, etc and breaks the flow. But this keyboard shortcut will work on any opened tab. It is a better user experience to those who really like the keyboard.
Relevant Issue: #1678

I know English. I have submitted the relevant PR to the l10n repo: zen-browser/l10n-packs#110

normaltaro and others added 2 commits December 11, 2024 21:58

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Feature labels Dec 11, 2024
@normaltaro normaltaro changed the title Shortcuts for Tab Navigation Prev/Next Shortcuts for Next/Prev Tab Navigation Dec 11, 2024
@mauro-balades
Copy link
Member

Great!

But we'll need to disable the other shortcuts.. Ill do that when I get home and ill merge

Copy link
Member

@mauro-balades mauro-balades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update LATEST_KBS_VERSION?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: normaltaro <[email protected]>
@normaltaro
Copy link
Author

done

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Signed-off-by: normaltaro <[email protected]>
@normaltaro
Copy link
Author

normaltaro commented Dec 16, 2024

do i move LATEST_KBS_VERSION to 6?

@goosethedev
Copy link

Any updates on this? 👀

@mauro-balades
Copy link
Member

Any updates on this? 👀

This ended up being not as easy as it looks... Im still investigating

@KorigamiK
Copy link

If anyone wants a workaround to get this feature you can try out my hotkeys config in the meantime which works good for me:

https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js

@Esyriz
Copy link

Esyriz commented Jan 22, 2025

If anyone wants a workaround to get this feature you can try out my hotkeys config in the meantime which works good for me:

https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js

I wasn't able to make this work but I used karabiner elements complex modifications instead to bind the keys i wanted to ctrl+tab and ctrl+shift+tab

{
    "description": "next/previoustab",
    "manipulators": [
        {
            "from": { "key_code": "f2" },
            "to": [
                {
                    "key_code": "tab",
                    "modifiers": "control"
                }
            ],
            "type": "basic"
        },
        {
            "from": { "key_code": "f1" },
            "to": [
                {
                    "key_code": "tab",
                    "modifiers": ["shift", "control"]
                }
            ],
            "type": "basic"
        }
    ]
}

@KorigamiK
Copy link

I wasn't able to make this work but I used karabiner elements complex modifications instead to bind the keys

Ah, nice although it's macos only

@pbogut
Copy link

pbogut commented Feb 10, 2025

If anyone wants a workaround to get this feature you can try out my hotkeys config in the meantime which works good for me:

https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js

@KorigamiK
Does it need to be enabled somehow in zen in order to work? I've put file in place, cleared startup cache but it doesn't look like file is loaded at all. Cheers.

@KorigamiK
Copy link

If anyone wants a workaround to get this feature you can try out my hotkeys config in the meantime which works good for me:
https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js

@KorigamiK Does it need to be enabled somehow in zen in order to work? I've put file in place, cleared startup cache but it doesn't look like file is loaded at all. Cheers.

No, you don't need to enable anything just place the files in the right locations.
See the docs here which explains how to install fx-autoconfig, for me on linux using zen the directory path is /opt/zen-browser-bin/defaults but it might be different for you.

then you paste my script https://github.com/KorigamiK/zen-conf/blob/main/chrome/JS/hotkeys.uc.js into chrome/JS/hotkeys.uc.js in your profile folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants