-
Notifications
You must be signed in to change notification settings - Fork 8
Use zls version according to Zig version #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run the extension as a dev extension and ran into a couple issues that made it clear to me this was not done previously. I've fixed some of the issues, namely compile errors and whitelisting the zig version
command, however, I don't have time right now to get everything working.
I would appreciate if you would try to use your branch as a dev extension for Zig, and take a crack at the remaining issues. It currently seems to not detect version mismatches between zig
and zls
whatsoever. My setup was trying to use mise
to set different versions of zig
on my path when launching Zed in a zig
project, and make sure the correct version of zls
was found, however, it never used anything besides zls
version 0.14
which I have installed globally
I tried it and it seems to be working, but I have no idea where's the log and where the error messages going. I didn't found any related documents about debugging extensions. Anyways I would like to work on these problems next week. |
This comment was marked as resolved.
This comment was marked as resolved.
Hey @CyanChanges, are you still working on this? |
This PR make the extension look for current version of installed
zig
, and try download a correspondingzls
binary.So users with dev version of
zig
, could download correct (dev) version ofzls
.