Zed only closes JDTLS Processes once every instance of Zed are closed/killed

[francescodedomenico]

Relevance Confirmation

• I confirmed that this is not an issue with the Eclipse JDT Language Server itself

What happened?

After opening a Java project the JDTLS Server starts, everything works correctly. If you do open a different project (in a new windows), lets say a Python project (no JDTLS Server running) and then close the Java Project the JDK process remains running until I do also close the Python project, consuming resources uselessly.
This may be slightly related to: #41 and fixed by: c64d7ad

But seems the cleanup policy happens only after every Zed instance is closed/killed.

What did you expect to happen?

I do expect that the JDK JDTLS process is killed when the Zed Instance/project who firstly spawned it is closed/killed, so I can keep my other projects open without having resources wasted.

Environment

Zed: 226.5
Platform: Windows 11 24h2
Java: Eclipse Adoptium jdk 25

[tartarughina]

@francescodedomenico thanks for reporting. Were you able to consistently reproduce the issue? Are these the correct steps?

• Open Java project
  • Wait for jdtls to start
• Open other project type
  • let the LSP start
• Close Java project
• Verify that the Java process running jdtls is still running

I'm working on a revised proxy that ditches Node in favor of Rust.
I've tested it on Mac and Linux, not yet on Windows.
Could you give it a go and let me know if the check done there works differently?

https://github.com/tartarughina/java --> branch rust-proxy

Compile the proxy and place it under the proxy-bin directory in your java extension directory alongside the directories for lombok, jdtls and the debugger.

[francescodedomenico]

Hello and you're welcome.
The steps to reproduce are correct, my example of the "other project" was a folder with just markdown files inside so I have only these available:

I have been trying following your steps (glad there's a plan for a rust-proxy) but without luck, the project itself do not compile on windows, I had to fix crates name and to adjust few functions calls not returning raw integers anymore but rather wrapped Results<,>.

I did finally compile the java-lsp-proxy.exe and put it into my proxy-bin directory (only proxy directory was available so I had to create it), I didnt' however appreaciate any change in the behavior, should I instruct the java extension to pass through the novel proxy tho? (maybe I should install your extension ad a dev extension inside zed?)

I might publish the modified code on my profle later so you might merge it.

EDIT:

I had indeed have to install the extension as a dev dependency, however I had to rename the java-lsp-proxy.exe to java-lsp-proxy because the PROXY_BINARY variable points to an extensionless binary.
Now I have the rust proxy working, however I am not sure if it's due to the changes I made the code myself to make it work in the first place

[tartarughina]

@francescodedomenico thanks for testing the proxy.
Sorry for the extra work you had to go through, I haven't thought to explicitly tell that the proxy to work required the development extension installed.

Did you use the justfile instruction to compile for windows? Could you report what have been the changes you had to make? For the latter a patch file would be lovely

Has the issue reoccured with the rust-proxy in place?

[tartarughina]

@francescodedomenico any update on this issue? Are you keep seeing it even after the release of the new proxy?

[tartarughina]

Closing as the issue is, as far as I could tell, being fixed once we moved to the new version of the proxy