Skip to content

Conversation

@LDeakin
Copy link
Member

@LDeakin LDeakin commented Nov 12, 2025

Closes #108

@LDeakin LDeakin requested a review from ilan-gold November 12, 2025 21:16
Copy link
Collaborator

@ilan-gold ilan-gold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some test cleanup would be nice but otherwise good

from zarr.abc.store import Store


class TestStrictModeDisabled:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two sets of tests could be smashed together and parametrized by codec_pipeline_strict so something like:

with pytest.raises(UnsupportedDataTypeError) if  codec_pipline_strict else null_context()
        arr[:] = data
if not codec_pipeline_strict:
        result = arr[:]
        assert np.array_equal(result, data)

@LDeakin LDeakin enabled auto-merge (squash) November 14, 2025 11:40
@LDeakin LDeakin merged commit 3cfa79a into main Nov 14, 2025
17 checks passed
@LDeakin LDeakin deleted the strict branch November 14, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Option to fail instead of falling back to zarr-python

3 participants