fix: keep fill value and attributes in from_array - #4288
Merged
d-v-b merged 1 commit intoAug 26, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4288 +/- ##
==========================================
+ Coverage 94.12% 94.19% +0.06%
==========================================
Files 92 92
Lines 12831 12825 -6
==========================================
+ Hits 12077 12080 +3
+ Misses 754 745 -9
🚀 New features to boost your workflow:
|
paraseba
force-pushed
the
fix-from-array-keep-fill-value-attributes
branch
from
August 26, 2026 04:25
fdb41f4 to
7b8b72e
Compare
`from_array` discards both `fill_value` and `attributes`. An explicit `fill_value=None` now means the dtype's default scalar (v3) or a null fill value (v2), consistent with `create_array`, and an empty `attributes` dict opts out of copying the source's attributes. Fixes zarr-developers#4287
paraseba
force-pushed
the
fix-from-array-keep-fill-value-attributes
branch
from
August 26, 2026 04:29
95b0cf9 to
b7decb5
Compare
Contributor
|
thanks @paraseba, this looks good. long term we will need to make breaking changes around our use of |
d-v-b
approved these changes
Aug 26, 2026
paraseba
added a commit
to xyf5432/icechunk
that referenced
this pull request
Aug 26, 2026
These errors were found by the nightly upstream-dev job. zarr >= 3.3's `add_array` recreates the drawn array in the store under test without the sharding codec the model store got, so an all-fill-value write elides a chunk object on one side only. Override it with the fix from zarr-developers/zarr-python#4288 until that reaches a release. `check_file_invariants` required orphan tx logs to equal the pruned-ancestor refs of every snapshot whose *file* is on disk. This is no longer true now that we keep expired tx logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from_arraydiscards bothfill_valueandattributes.An explicit
fill_value=Nonenow means the dtype's default scalar (v3) or a null fill value (v2), consistent withcreate_array, and an emptyattributesdict opts out of copying the source's attributes.Fixes #4287
Author attestation