-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update version policy to use effver #2910
update version policy to use effver #2910
Conversation
Co-authored-by: Joe Hamman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @d-v-b -- this looks great!
Co-authored-by: Joe Hamman <[email protected]>
@zarr-developers/python-core-devs it would be good to get yalls eyes on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this! I left some comments inline. I think a major gap in the policy as it stands is that it doesn't embody @TomAugspurger's excellent points of being considerate to downstream users by:
- preserving backwards compatibility where possible
- giving notice of deprecations through FutureWarnings
- giving users and libraries time to adapt to those deprecations
Matplotlib has some good guidelines on making breaking API changes using deprecations which could be taken as inspiration here.
Co-authored-by: David Stansby <[email protected]>
Co-authored-by: David Stansby <[email protected]>
Co-authored-by: David Stansby <[email protected]>
|
does anyone else think a community announcement (e.g. a blog post) would make sense here? If so, I can start working on one |
Thanks for working on this, @d-v-b! Important change.
We should at least make a social media announcement on BlueSky, LinkedIn, and Mastodon. A blog post would be great! I can take care of the announcements and help with blog writing/review. A minor suggestion: Can we wrap the text to 80 (or similar) columns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @d-v-b for leading us through this.
This changes the versioning policy from something semver-ish to effver.
based on conversations in this issue
TODO:
docs/user-guide/*.rst
changes/
closes #2889