-
Notifications
You must be signed in to change notification settings - Fork 106
(chore) Type hints for abc codec codec_id attribute
#702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
codec_id attribute
|
i'm just annotating the type of the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #702 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 63 63
Lines 2754 2754
=======================================
Hits 2753 2753
Misses 1 1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 , just one suggestion, feel free to take or leave and then merge
|
I think my suggested change (that I applied) revealed (sort of) a real issue - |
I'm not sure how to type the buffer parameters. As long as we have a
picklecodec, I don't think it's possible to restrict the return type ofdecodeto anything narrower thanobject.