Pg/hpu bench fix #2355
Merged
Pg/hpu bench fix #2355
+9
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
reviewed
May 19, 2025
tfhe/examples/hpu/bench.rs
Outdated
Comment on lines
263
to
270
| let res_hpu = (0..args.iter) | ||
| .map(|_i| { | ||
| let res = HpuRadixCiphertext::exec(&proto, iop.opcode(), &srcs_enc, &imms); | ||
| std::hint::black_box(&res); | ||
| res | ||
| }) | ||
| .next_back() | ||
| .last() | ||
| .expect("Iteration must be greater than 0"); |
There was a problem hiding this comment.
better to loop or collect first, iterators being greedy, without comment here it's easy to re introduce the bug
There was a problem hiding this comment.
Done in the last commit.
We now explicitly collect intermediate results in a vector
hpu_bench example was wrong for iter > 1 following clippy modifications. NB: Vector is collect but intermediate value are explicitly drop to enable long-time stressed tests.
Bapt-Roux
force-pushed
the
pg/hpu_bench_fix
branch
from
03eac43 to
41bf88a
Compare
|
Commits were squashed and rebased on main. |
Bapt-Roux
approved these changes
May 28, 2025
IceTDrinker
approved these changes
May 28, 2025
Comment on lines
+265
to
+269
| if i == (args.iter - 1) { | ||
| Some(res) | ||
| } else { | ||
| None | ||
| } |
There was a problem hiding this comment.
Just for the record, there could be a world where a very smart optimizer might trivialize this and not run some perf stuff, but thankfully today it works so all good :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is appearing when running bench with iter > 1, for example:
cargo run --profile devo --features=integer,internal-keycache,hpu-v80 --example hpu_bench -- --iter 10 --integer-w 64because of usage of .next_back() measured latency is only the latency of the 1st operation.
No emergency to merge.