chore(deps): bump rand 0.8 -> 0.9.1, rand_core 0.6.4 -> 0.9.3 #2335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmks
force-pushed
the
chore/bump-rand-crates
branch
from
2e5fa0a to
97583c2
Compare
mkmks
force-pushed
the
chore/bump-rand-crates
branch
5 times, most recently
from
295779c to
8a6723e
Compare
mkmks
force-pushed
the
chore/bump-rand-crates
branch
from
8a6723e to
893632e
Compare
tmontaigu
reviewed
May 20, 2025
Comment on lines
+58
to
+62
| ark-std = { git = "https://github.com/tcoratger/std.git", branch = "rand" } | ||
| ark-bls12-381 = { git = "https://github.com/mkmks/ark-algebra.git" } | ||
| ark-ec = { git = "https://github.com/mkmks/ark-algebra.git" } | ||
| ark-ff = { git = "https://github.com/mkmks/ark-algebra.git" } | ||
| ark-poly = { git = "https://github.com/mkmks/ark-algebra.git" } |
There was a problem hiding this comment.
Are the changes in these repo being proposed into the upstream ?
Otherwise we would be blocked to release the crate to tfhe-rs, unless we push these forks of ark to crates.io
|
let's close this if we are not moving ahead for now ? @mkmks |
|
Yes, let's revisit the issue later when dependencies are updated upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.