Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces 2 different fallback mechanisms (possible overlapping):
DefaultLogbook
. Where request stage preparing method (RequestWritingStage process(final HttpRequest originalRequest, final Strategy strategy)
), as well as request writing and response write methods of theDefaultRequestWritingStage
(new inner class) will be intercepting allRuntimeExceptions
and will not fail the request processing. This approach may be sufficient to cover the cases of library dependent interceptors.Motivation and Context
As of now, when Logbook is causing RuntimeExceptions, it affects not only the ability to write the request/response logs, but prevents clients from operating normally. This should not be the case.
Related issues: #1693, #1702
Types of changes
Checklist: