Synchronize ingress annotations on all traffic segments. #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
… annotations. Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
myaser
reviewed
Jan 17, 2024
|
👍🏻 |
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
Signed-off-by: Rodrigo Reis <[email protected]>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) adds a feature to synchronize annotations on all traffic segments (Ingress and/or RouteGroup).
When the controller starts with a configuration file specifying which annotation keys to synchronize, if a user creates or updates a StackSet where the Ingress or RouteGroup section contain one or many of the synchronized annotations, the reconciler will then ensure that all Ingress or RouteGroup traffic segment resources from Stacks contain the synchronized annotations.
Conversely, if a user removes one of the synchronized annotations from the StackSet's Ingress or RouteGroup definition, the reconciler will in turn delete the annotation on all Stack's Ingress or RouteGroup traffic segment resources.
We define the annotation keys to synchronize using the variadic flag
--sync-ingress-annotation.All the generated client code in
pkg/clientandpkg/apis/zalando-org/v1is due to the fact that it's 2024 🙂