Skip to content

Commit

Permalink
create missing configmap
Browse files Browse the repository at this point in the history
  • Loading branch information
linki committed Dec 18, 2023
1 parent 2d7b387 commit c2d893c
Showing 1 changed file with 21 additions and 5 deletions.
26 changes: 21 additions & 5 deletions cmd/e2e/basic_test.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package main

import (
"context"
"fmt"
"slices"
"sort"
Expand All @@ -17,6 +18,7 @@ import (
autoscalingv2 "k8s.io/api/autoscaling/v2"
corev1 "k8s.io/api/core/v1"
v1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/intstr"
)

Expand Down Expand Up @@ -65,9 +67,21 @@ func NewTestStacksetSpecFactory(stacksetName string) *TestStacksetSpecFactory {
}
}

func (f *TestStacksetSpecFactory) ConfigMap() *TestStacksetSpecFactory {
func (f *TestStacksetSpecFactory) ConfigMap(configMapName string, data map[string]string) (*TestStacksetSpecFactory, error) {
configMap := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: configMapName,
},
Data: data,
}

_, err := configMapInterface().Create(context.Background(), configMap, metav1.CreateOptions{})
if err != nil {
return nil, err
}

f.configMap = true
return f
return f, nil
}

func (f *TestStacksetSpecFactory) Behavior(stabilizationWindowSeconds int32) *TestStacksetSpecFactory {
Expand Down Expand Up @@ -146,8 +160,9 @@ func (f *TestStacksetSpecFactory) Create(stackVersion string) zv1.StackSetSpec {
result.StackTemplate.Spec.ConfigurationResources = []zv1.ConfigurationResourcesSpec{
{
ConfigMapRef: corev1.LocalObjectReference{
// ConfigurationResource name must be prefixed by Stack name. ConfigurationResource: foo-v1-test-configmap, Stack: stackset-create-central-configmap-v1
// TODO make stackset name configurable
// DONE ConfigurationResource name must be prefixed by Stack name. ConfigurationResource: foo-v1-test-configmap, Stack: stackset-create-central-configmap-v1
// DONE TODO make stackset name configurable
// Unable to reconcile stack resources: configmaps \"stackset-create-central-configmap-v1-configmap\" not found
// TODO create the referenced configmap
Name: fmt.Sprintf("%s-%s-configmap", f.stacksetName, stackVersion),
},
Expand Down Expand Up @@ -623,7 +638,8 @@ func testStacksetCreate(
stackVersion := "v1"
stacksetSpecFactory := NewTestStacksetSpecFactory(stacksetName)
if configmap {
stacksetSpecFactory.ConfigMap()
_, err := stacksetSpecFactory.ConfigMap(fmt.Sprintf("%s-%s-configmap", stacksetName, stackVersion), map[string]string{})
require.NoError(t, err)
}
if hpa {
stacksetSpecFactory.Autoscaler(
Expand Down

0 comments on commit c2d893c

Please sign in to comment.