Fix incorrect alt for screenshot <img>
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alt text was set to "Screenshot for v1.screenshot.11ty.dev" instead of "Screenshot for github.com/example/foo". The alt text for the opengraph version of this was set correctly already, but in this function the name "targetUrl" and "fullUrl" carried a different meaning than elsewhere in the same file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The alt text is set to "Screenshot for v1.screenshot.11ty.dev", followed by a percent-encoded version of the URL, instead of simply "Screenshot for github.com/example/foo".
https://www.zachleat.com/web/eleventy-three-beta/
Example of what it looks like in Firefox while the image is loading and/or if the image fails to load for some network connectivity reason:
Solution:
I've not tested or confirmed this, but this might be coming from
_11ty/imagePlugin.jswhere there seems to be a mixup between the "targetUrl" and "fullUrl" variable names, which carry the opposite meaning than they do elsewhere in the same file. The opengraph version and its alt text was set correctly already.