updating enhancement #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge from scoopex
|
Great! Lets continue that. |
scoopex
reviewed
May 22, 2025
scoopex
reviewed
May 22, 2025
README.md
Outdated
| * tls: Check tls secrets expiration dates | ||
|
|
||
| For details or a overview of the monitored kubernetes attributes, have a look at the [documentation](http://htmlpreview.github.io/?https://github.com/zabbix-tooling/k8s-zabbix/blob/master/documentation/template/custom_service_kubernetes.html) | ||
| For details or a overview of the monitored kubernetes attributes, have a look at the [documentation](http://htmlpreview.github.io/?https://github.com/vico-research-and-consulting/k8s-zabbix/blob/master/documentation/template/custom_service_kubernetes.html) |
There was a problem hiding this comment.
yes, if you have some ideas, feel free for more generic
There was a problem hiding this comment.
Can we use the original url without the company name?
There was a problem hiding this comment.
if the project is merged again, i'm fine with links to zabbix-tooling
scoopex
reviewed
May 22, 2025
scoopex
reviewed
May 23, 2025
scoopex
reviewed
Jun 30, 2025
Comment on lines
+1
to
+2
| FROM python:3.11 | ||
| LABEL maintainer="[email protected]" |
There was a problem hiding this comment.
Just remove the maintainer reference.
Probably updating to python 3.13 is something we can do in this step (but not mandatory from review perspective)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here is the update from the parallel work, check if it can be used on both sides.
gitlab compare on website seems to be broken, the displayed file changes are not correct