Skip to content

decision: Copilot review triggers and a documented fallback when a review request is not registered #642

Description

@ss-o

Problem

ADR-0013 requires or suggests Copilot code review per repository class and AGENTS.md makes a pull request done only after every configured review has posted. Nothing says when a review is triggered or what happens when Copilot cannot review.

On 2026-09-19 one maintainer session spent ten Copilot reviews across five repositories: seven rulesets carry review_on_push: true and review_draft_pull_requests: true (zi, .github, z-a-meta-plugins, zd, zsh-eza, zunit, zsh-zoxide), so every push billed a review, including two on gitlink-only pull requests in the private meta-workspace and three fix rounds on one policy pull request. By the last pull request of the day the review request was accepted by the API (POST /pulls/{n}/requested_reviewers returned 200) but never registered: no review_requested timeline event, no run, no review. The maintainer merged by explicit decision, outside any documented bypass.

Change

Propose an ADR that: sets Copilot review to explicit request when a pull request is ready (review_on_push and review_draft_pull_requests false in every class, rule presence unchanged); names the review executed under .github/skills/code-review/SKILL.md against code-review-generic.instructions.md, posted by the maintainer with inline threads, as the documented fallback for classes 2, 3 and 4 when a Copilot request is not registered; keeps class 1 waiting for Copilot or a second human; and lets a repository declare automation-only diff classes (gitlink moves, dependency bumps) that need no review. Update the AGENTS.md done gate to reference it.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    type:maintenanceNon-feature maintenance, cleanup, or org work.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions