Merge pull request #1005 from ioito/hotfix/qx-secgroup-rule-create

fix(qcloud): security group rule create
yunionio · Jul 1, 2024 · 1e444b8 · 1e444b8
2 parents d11cc99 + 6898ba6
commit 1e444b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/pkg/multicloud/google/securitygroup.go b/pkg/multicloud/google/securitygroup.go
@@ -131,6 +131,9 @@ func (self *SGoogleClient) CreateSecurityGroupRule(globalnetworkId, tag string,
 		"direction":   "INGRESS",
 		"targetTags":  []string{strings.ToLower(tag)},
 	}
+	if len(opts.CIDR) == 0 {
+		opts.CIDR = "0.0.0.0/0"
+	}
 	if opts.Direction == secrules.DIR_OUT {
 		body["direction"] = "EGRESS"
 		body["destinationRanges"] = []string{opts.CIDR}

diff --git a/pkg/multicloud/qcloud/securitygroup.go b/pkg/multicloud/qcloud/securitygroup.go
@@ -338,6 +338,9 @@ func (self *SRegion) CreateSecurityGroupRule(groupId string, opts *cloudprovider
 	if opts.Action == secrules.SecurityRuleDeny {
 		action = "drop"
 	}
+	if len(opts.CIDR) == 0 {
+		opts.CIDR = "0.0.0.0/0"
+	}
 	params := map[string]string{
 		"SecurityGroupId":            groupId,
 		prefix + "PolicyIndex":       fmt.Sprintf("%d", opts.Priority),