Changes related to issue #54 #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut number of notes accurate
…9+9, 7-9+11, 7+9+11 and 7-9-13
…5, -9+5, +11, -9+9, -9+11, +9+11, -13, -9-13, -13-9
… the current quality
|
Hi @koto-wheel, thank you for your contribution. I want to keep backward compatibility before merging this. I have an idea to do that and create ticket #58. Could you kindly take a look and please comment if you have any feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items in these changes
Item 1: add some quality aliases:
item 2: declare 11th qualities as 6 notes chords
item 3: declare 13th qualities as 7 notes chords
Reorder QUALITY_DICT in order to make comments on number of notes accurate
Can you take these changes into account please.