Fixing Chord.from_note_index() so it chooses the correct accidentals #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuma-m
reviewed
Jun 20, 2020
| root = scale[:-3] | ||
| # if scale is minor, get sharp/flat from relative major | ||
| if scale[-3:] == 'min': | ||
| root = SCALE_VAL_DICT[root][3] |
There was a problem hiding this comment.
I think this always returns D# or Eb, is it what do you intended?
Do you mean below?
root = SCALE_VAL_DICT[root][(NOTE_VAL_DICT(root) + 3) % 12]
|
Thank you for your contribution and sorry for the late reply. |
yuma-m
reviewed
Jun 20, 2020
| root = root_options[0] | ||
| else: | ||
| correct_accidental = sharp_or_flat(scale) | ||
| correct_index = ['FLATTED','SHARPED'].index(correct_accidental) |
There was a problem hiding this comment.
Suggested change
| correct_index = ['FLATTED','SHARPED'].index(correct_accidental) | |
| correct_index = ['FLATTED', 'SHARPED'].index(correct_accidental) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that the from_note_index class method does some possibly undesirable things with accidentals. For example,
returns
<Chord: Ab>.I have used your
SHARPED_SCALEconstant and a helper functionutils.sharp_or_flatto use the underlying scale to determine the correct accidental. In this example, this makes the function return `<Chord: G#>' instead, which is more conventional.It also makes
TestChordFromNoteIndex.test_note_2fromtest_chord.pypass (it was previously failing).