Skip to content

Conversation

es1024
Copy link
Contributor

@es1024 es1024 commented Oct 10, 2025

This PR removes clang 17 builds and adds clang 21 builds.

Changes required for clang 21:

  • Remove -c when running preprocessor. Clang 21 now emits a warning for unnecessary -c:
clang: error: argument unused during compilation: '-c' [-Wunused-command-line-argument]
  • Bump cassandra-cpp-driver to 2.9.0-yb-16 to address the following error:
[cassandra-cpp-driver (clang21, uninstrumented)] src/cassandra-cpp-driver-2.9.0-yb-15/src/md5.cpp:151:10: error: first argument in call to 'memset' is a pointer to non-trivially copyable type 'cass::Md5' [-Werror,-Wnontrivial-memcall]
[cassandra-cpp-driver (clang21, uninstrumented)]   151 |   memset(this, 0, sizeof(Md5));
[cassandra-cpp-driver (clang21, uninstrumented)]       |          ^
[cassandra-cpp-driver (clang21, uninstrumented)] src/cassandra-cpp-driver-2.9.0-yb-15/src/md5.cpp:151:10: note: explicitly cast the pointer to silence this warning
[cassandra-cpp-driver (clang21, uninstrumented)]   151 |   memset(this, 0, sizeof(Md5));
[cassandra-cpp-driver (clang21, uninstrumented)]       |          ^
[cassandra-cpp-driver (clang21, uninstrumented)]       |          (void*)
[cassandra-cpp-driver (clang21, uninstrumented)] 1 error generated.

Also bump llvm-installer to 1.4.12 (BOLT binaries for llvm21 builds).

@es1024 es1024 changed the title [WIP] Add clang21 support + remove clang17 Add clang21 support + remove clang17 Oct 10, 2025
Copy link
Contributor

@SrivastavaAnubhav SrivastavaAnubhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backports to 2024.2 still need clang17 for CI

@es1024
Copy link
Contributor Author

es1024 commented Oct 13, 2025

2024.2 has its own thirdparty branch already so this won't affect it. 2025.1 is fine but probably should also get a branch soon.

@es1024 es1024 marked this pull request as draft October 14, 2025 09:03
@es1024 es1024 marked this pull request as ready for review October 15, 2025 03:08
@es1024 es1024 merged commit 3fd3636 into yugabyte:master Oct 16, 2025
22 of 44 checks passed
@es1024 es1024 deleted the clang21 branch October 16, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants