Patch libedit to ignore missing history cookie #310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the issue with ysqlsh history by patching libedit to ignore the missing history cookie during file truncation.
- Added a new patch file ('libedit-ignore-missing-cookie.patch') to ensure history is loaded even if the cookie is missing.
- Updates the build definitions to incorporate the patch in the libedit build process.
Files not reviewed (1)
- patches/libedit-ignore-missing-cookie.patch: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have an issue (yugabyte/yugabyte-db#9861) that causes
ysqlshhistory to not work between sessions.We truncate the history file to the size limit (default 500) each time we write to it, keeping the 500 newest history commands and deleting the older ones. Libedit keeps a cookie at the beginning of the history file (after the oldest line of history). During truncation, the cookie gets deleted. The next time we try to load the history file, libedit sees that the cookie is missing and does not load the history file. This is a bug in libedit and is known to affect vanilla PostgreSQL as well.
To fix this, we patch libedit to load the file even if the cookie is missing.